From 19be5d8c587ae081957ce967e43cdb028df9e0ba Mon Sep 17 00:00:00 2001 From: Faiyaz Rahman Date: Wed, 2 Sep 2026 22:02:52 +0000 Subject: [PATCH] caddyhttp: remove unused QUICConfig from the HTTP/3 server (#7980) Signed-off-by: Faiyaz Rahman --- modules/caddyhttp/server.go | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/modules/caddyhttp/server.go b/modules/caddyhttp/server.go index 809bb0cd5..0f4ed8ec3 100644 --- a/modules/caddyhttp/server.go +++ b/modules/caddyhttp/server.go @@ -32,9 +32,7 @@ import ( "time" "github.com/caddyserver/certmagic" - "github.com/quic-go/quic-go" "github.com/quic-go/quic-go/http3" - h3qlog "github.com/quic-go/quic-go/http3/qlog" "go.uber.org/zap" "go.uber.org/zap/zapcore" @@ -1036,11 +1034,10 @@ func (s *Server) serveHTTP3(addr caddy.NetworkAddress, tlsCfg *tls.Config) error Handler: s, TLSConfig: tlsCfg, MaxHeaderBytes: s.MaxHeaderBytes, - QUICConfig: &quic.Config{ - Versions: []quic.Version{quic.Version1, quic.Version2}, - InitialPacketSize: 1200, - Tracer: h3qlog.DefaultConnectionTracer, - }, + // QUICConfig is deliberately unset: http3.Server only reads it when it + // creates its own listener (ListenAndServe/Serve). We bring our own + // listener and call ServeListener, so anything set here is ignored. + // The QUIC settings that actually apply are in NetworkAddress.ListenQUIC. IdleTimeout: time.Duration(s.IdleTimeout), } }