admin: stabilise log redaction test (#7942)
parent
7bf1b9057b
commit
502691f518
|
|
@ -271,19 +271,21 @@ func TestAdminHandlerServeHTTPRedactsSensitiveHeadersInLogs(t *testing.T) {
|
||||||
handler := adminHandler{
|
handler := adminHandler{
|
||||||
mux: http.NewServeMux(),
|
mux: http.NewServeMux(),
|
||||||
}
|
}
|
||||||
req := httptest.NewRequest(http.MethodGet, "/", nil)
|
req := httptest.NewRequest(http.MethodGet, "/redaction-test", nil)
|
||||||
req.Header.Set("Authorization", "Bearer secret")
|
req.Header.Set("Authorization", "Bearer secret")
|
||||||
req.Header.Set("Cookie", "session=secret")
|
req.Header.Set("Cookie", "session=secret")
|
||||||
req.Header.Set("X-Test", "ok")
|
req.Header.Set("X-Test", "ok")
|
||||||
rr := httptest.NewRecorder()
|
rr := httptest.NewRecorder()
|
||||||
|
|
||||||
|
Log().Info("unrelated test log")
|
||||||
handler.ServeHTTP(rr, req)
|
handler.ServeHTTP(rr, req)
|
||||||
|
|
||||||
if logs.Len() == 0 {
|
entries := logs.FilterMessage("received request").FilterField(zap.String("uri", req.RequestURI)).All()
|
||||||
t.Fatal("expected request log entry")
|
if len(entries) != 1 {
|
||||||
|
t.Fatalf("request log entries = %d, want 1", len(entries))
|
||||||
}
|
}
|
||||||
|
|
||||||
ctx := logs.All()[0].ContextMap()
|
ctx := entries[0].ContextMap()
|
||||||
headers, ok := ctx["headers"].(map[string]any)
|
headers, ok := ctx["headers"].(map[string]any)
|
||||||
if !ok {
|
if !ok {
|
||||||
t.Fatalf("expected headers field in log context, got %T", ctx["headers"])
|
t.Fatalf("expected headers field in log context, got %T", ctx["headers"])
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue