base: Don't fix Y2038 problem with icu

pull/792/head
klzgrad 2020-11-18 22:51:53 +08:00
parent 515bc6ccb2
commit dd3c44be83
3 changed files with 4 additions and 2 deletions

View File

@ -2306,7 +2306,7 @@ component("base") {
# headers which allows representing time as int64, which makes this entire
# problem moot. Hence, why `!is_cronet_build` flag has been added.
# See crbug.com/431972096#comment10 for more information.
if (!is_castos && !is_cast_android && !is_cronet_build) {
if (false) {
sources += [ "time/time_exploded_icu.cc" ]
# The ICU dependency is only needed on systems with a 32-bit time_t.

View File

@ -828,6 +828,7 @@ class BASE_EXPORT Time : public time_internal::TimeBase<Time> {
// Some platforms use the ICU library to provide To/FromExploded, when their
// native library implementations are insufficient in some way.
#if 0
static void ExplodeUsingIcu(int64_t millis_since_unix_epoch,
bool is_local,
Exploded* exploded);
@ -835,6 +836,7 @@ class BASE_EXPORT Time : public time_internal::TimeBase<Time> {
bool is_local,
const Exploded& exploded,
int64_t* millis_since_unix_epoch);
#endif
// Rounds down the time to the nearest day in either local time
// |is_local = true| or UTC |is_local = false|.

View File

@ -130,7 +130,7 @@ void Time::Explode(bool is_local, Exploded* exploded) const {
if (sizeof(SysTime) < 8) {
// TODO(b/167763382) Find an alternate solution for Chromecast devices, since
// adding the icui18n dep significantly increases the binary size.
#if !BUILDFLAG(IS_CASTOS) && !BUILDFLAG(IS_CAST_ANDROID)
#if 0
ExplodeUsingIcu(millis_since_unix_epoch, is_local, exploded);
return;
#endif // !BUILDFLAG(IS_CASTOS) && !BUILDFLAG(IS_CAST_ANDROID)