FreeDV Reporter: don't select the row under the mouse on focus without a click; begin 2.4.2 development (#1611)

* FreeDV Reporter: only select the row under the mouse on focus if a button is down.

OnSetFocus() selected whatever row the mouse was over whenever the list
gained the focus, including when that came from the window being brought
to the front or a tooltip closing rather than a click. On Linux the
selection guard doesn't stop this either, as hovering over a row already
allows selections. This caused an occasional gui_reporter_row_actions
failure on v3.0-dev ("Selected stations after hovering messages is
['K1ABC']").

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019q8F5ZSDKDxXJoLJTFQ8wN

* Add PR #1611 to changelog.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019q8F5ZSDKDxXJoLJTFQ8wN

* Re-enable dev version tag and six-month build expiry now that 2.4.1 is out.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019q8F5ZSDKDxXJoLJTFQ8wN

* Increment version to 2.4.2 to begin development.

Also builds against freedv-backend's main branch again instead of the
v1.0.1 release, as was done when 2.4.1 development began (#1473).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019q8F5ZSDKDxXJoLJTFQ8wN

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
pull/1613/head
Mooneer Salem 2026-10-31 17:11:38 -07:00 committed by GitHub
parent 321db15f63
commit 102aa6e483
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 18 additions and 4 deletions

View File

@ -15,7 +15,7 @@ endif()
set(CMAKE_OSX_DEPLOYMENT_TARGET "11.0" CACHE STRING "Minimum OS X deployment version")
set(PROJECT_NAME FreeDV)
set(PROJECT_VERSION 2.4.1)
set(PROJECT_VERSION 2.4.2)
set(PROJECT_DESCRIPTION "HF Digital Voice for Radio Amateurs")
set(PROJECT_HOMEPAGE_URL "https://freedv.org")
@ -59,12 +59,12 @@ endif(NOT DEFINED LINUX)
# Adds a tag to the end of the version string. Leave empty
# for official release builds.
if(NOT DEFINED FREEDV_VERSION_TAG)
set(FREEDV_VERSION_TAG "")
set(FREEDV_VERSION_TAG "dev")
# Uncomment the below definition to cause the build to expire
# six months from the day it was built. This should be commented
# for official releases.
#add_definitions(-DUNOFFICIAL_RELEASE)
add_definitions(-DUNOFFICIAL_RELEASE)
endif(NOT DEFINED FREEDV_VERSION_TAG)
# Prevent in-source builds to protect automake/autoconf config.

View File

@ -947,6 +947,11 @@ LDPC | Low Density Parity Check Codes - a family of powerful FEC codes
# Release Notes
## V2.4.2 TBD 2026
1. Bugfixes:
* FreeDV Reporter: don't select the station under the mouse when the list gains focus without a click. (PR #1611)
## V2.4.1 October 2026
1. Bugfixes:

View File

@ -3,7 +3,7 @@ include(FetchContent)
FetchContent_Declare(
freedv_backend
GIT_REPOSITORY https://github.com/freedv/freedv-backend
GIT_TAG v1.0.1
GIT_TAG main
)
FetchContent_MakeAvailable(freedv_backend)

View File

@ -1815,6 +1815,15 @@ void FreeDVReporterDialog::OnLeftClickTooltip(wxMouseEvent& event)
void FreeDVReporterDialog::OnSetFocus(wxFocusEvent& event)
{
// Only select the item under the mouse if the focus came from clicking
// on it, not from e.g. the window being brought to the front or a
// tooltip closing while the mouse happens to be over the list.
if (!wxGetMouseState().ButtonIsDown(wxMOUSE_BTN_ANY))
{
event.Skip();
return;
}
CallAfter([this]() {
const wxPoint pt = wxGetMousePosition();
int mouseX = pt.x - m_listSpots->GetScreenPosition().x;