FreeDV
/
freedv-gui
mirror of https://github.com/drowe67/freedv-gui.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Work around Linux bug preventing some flag emojis from being fully deleted on backspace. (#931) 

* Work around Linux bug preventing some flag emojis from being fully deleted on backspace.

* Make cursor appear in the expected location after deletion.

* Add PR #931 to changelog.
pull/935/head
Mooneer Salem 2025-06-12 08:28:33 -07:00 committed by GitHub
parent fa07b1aa85
commit 56e39f05f1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 67 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
USER_MANUAL.md
View File

@ -802,6 +802,7 @@ LDPC | Low Density Parity Check Codes - a family of powerful FEC codes
* Fix WASAPI errors on some machines by supporting audio mix formats other than 16-bit integer. (PR #919)
* Reduce CPU usage of FreeDV Reporter window by only re-sorting if we actually get new data from the server. (PR #915)
* FreeDV Reporter: Fix issue with first column not being aligned properly with other columns. (PR #922)
* FreeDV Reporter: Work around Linux bug preventing some flag emojis from being fully deleted on backspace. (PR #931)
* Fix GTK+ assertion after FreeDV Reporter has been open for a long time. (PR #929)
2. Documentation:
* Add missing dependency for macOS builds to README. (PR #925; thanks @relistan!)

67
src/gui/dialogs/freedv_reporter.cpp
View File

@ -989,11 +989,76 @@ void FreeDVReporterDialog::OnCopyUserMessage(wxCommandEvent& event)
void FreeDVReporterDialog::OnStatusTextChange(wxCommandEvent& event)
{
auto statusMsg = m_statusMessage->GetValue();
int insertPoint = m_statusMessage->GetInsertionPoint();
log_debug("Status message currently %s", (const char*)statusMsg.ToUTF8());
// Linux workaround: it's possible for some emoji flags to backspace
// and not fully remove the flag. This logic scans the current value
// of statusMsg for the appropriate Unicode sequence
// (U+1F3F4 + ... + U+E007F). If the beginning character is there
// but not the end character, the intermediate tag characters are
// removed along with the beginng.
//
// Note: it still takes a couple of backspaces before the delete process
// begins so this is not a full workaround. Still, this significantly
// reduces the number of times one must backspace in order to completely
// remove the flag.
int index = 0;
while (index < statusMsg.Length())
{
auto chr = statusMsg.GetChar(index);
if (chr.GetValue() == 0x1F3F4)
{
log_debug("Found start char at index %d", index);
auto endIndex = index + 1;
bool foundEnd = false;
while (endIndex < statusMsg.Length())
{
auto endChar = statusMsg.GetChar(endIndex).GetValue();
if (endChar == 0xE007F)
{
foundEnd = true;
break;
}
else if (!(endChar >= 0xE0061 && endChar <= 0xE007A))
{
// Not lowercase tag characters; missing end character.
endIndex--;
break;
}
endIndex++;
}
log_debug("Found end at %d", endIndex);
if (!foundEnd && endIndex != index)
{
// Strip tag characters and beginning
statusMsg = statusMsg.SubString(0, index - 1) + statusMsg.Mid(endIndex + 1);
insertPoint = index;
log_debug("status msg is now %s", (const char*)statusMsg.ToUTF8());
}
else
{
index = endIndex;
}
}
else if (chr.GetValue() >= 0xE0000 && chr.GetValue() <= 0xE007F)
{
// Remove any stray tag characters that might still remain.
statusMsg.Remove(index, 1);
continue;
}
index++;
}
// Prevent entry of text longer than the character limit.
if (statusMsg != m_statusMessage->GetValue())
{
m_statusMessage->SetValue(statusMsg);
// Reset cursor position to end of new character
m_statusMessage->SetInsertionPoint(insertPoint);
}
}