FreeDV
/
freedv-gui
mirror of https://github.com/drowe67/freedv-gui.git
1
0
Fork 0
Code Issues Releases Wiki Activity

FreeDV Reporter: Force explicit background color when not highlighted. (#911) 

* FreeDV Reporter: Force explicit background color when not highlighted.

* Add PR #911 to changelog.
pull/917/head
Mooneer Salem 2025-06-05 12:39:18 -07:00 committed by GitHub
parent 1eec2b66ed
commit d6ff70a7da
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
USER_MANUAL.md
View File

@ -795,6 +795,7 @@ LDPC | Low Density Parity Check Codes - a family of powerful FEC codes
1. Bugfixes: 1. Bugfixes:
* Reduce latency when going between TX->RX with Hamlib configured. (PR #893) * Reduce latency when going between TX->RX with Hamlib configured. (PR #893)
* Reduce usage of non-real time safe code. (PR #900) * Reduce usage of non-real time safe code. (PR #900)
* FreeDV Reporter: Force explicit background color (avoids unwanted mouseover highlights on Linux). (PR #911)
* Fix compiler errors when using wxWidgets 3.0. (PR #914) * Fix compiler errors when using wxWidgets 3.0. (PR #914)
## V2.0.0 June 2025 ## V2.0.0 June 2025

16
src/gui/dialogs/freedv_reporter.cpp
View File

@ -740,8 +740,8 @@ void FreeDVReporterDialog::FreeDVReporterDataModel::updateHighlights()
reportData->lastUpdateUserMessage.ToUTC().IsEqualUpTo(curDate, wxTimeSpan(0, 0, MSG_COLORING_TIMEOUT_SEC)); reportData->lastUpdateUserMessage.ToUTC().IsEqualUpTo(curDate, wxTimeSpan(0, 0, MSG_COLORING_TIMEOUT_SEC));
// Messaging notifications take highest priority. // Messaging notifications take highest priority.
wxColour backgroundColor; wxColour backgroundColor = wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOW);
wxColour foregroundColor; wxColour foregroundColor = wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOWTEXT);
if (isMessaging) if (isMessaging)
{ {
@ -2001,6 +2001,18 @@ void FreeDVReporterDialog::FreeDVReporterDataModel::onUserConnectFn_(std::string
temp->lastRxMode = UNKNOWN_STR; temp->lastRxMode = UNKNOWN_STR;
temp->snr = UNKNOWN_STR; temp->snr = UNKNOWN_STR;
// Default to sane colors for rows. If we need to highlight, the timer will change
// these later.
//
#if defined(__APPLE__)
// To ensure that the columns don't have a different color than the rest of the control.
// Needed mainly for macOS.
temp->backgroundColor = wxColour(wxTransparentColour);
#else
temp->backgroundColor = wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOW);
#endif // defined(__APPLE__)
temp->foregroundColor = wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOWTEXT);
auto lastUpdateTime = makeValidTime_(lastUpdate, temp->lastUpdateDate); auto lastUpdateTime = makeValidTime_(lastUpdate, temp->lastUpdateDate);
temp->lastUpdate = lastUpdateTime; temp->lastUpdate = lastUpdateTime;
temp->connectTime = temp->lastUpdateDate; temp->connectTime = temp->lastUpdateDate;