FreeDV Reporter: Fix issue with first column not being aligned properly with other columns. (#922)

* FreeDV Reporter: Fix issue with first column not being aligned properly with other columns in Windows.

* Add PR #922 to changelog.
ms-reporter-cpu-usage^2
Mooneer Salem 2025-06-10 08:42:59 -07:00 committed by GitHub
parent 1b30e30ba7
commit f856cb2124
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 15 additions and 14 deletions

View File

@ -800,6 +800,7 @@ LDPC | Low Density Parity Check Codes - a family of powerful FEC codes
* Unit tests: Increase sleep time before killing recording to resolve macOS test failures. (PR #917)
* Fix typo causing RX radio device to remain open. (PR #918)
* Fix WASAPI errors on some machines by supporting audio mix formats other than 16-bit integer. (PR #919)
* FreeDV Reporter: Fix issue with first column not being aligned properly with other columns. (PR #922)
2. Documentation:
* Add missing dependency for macOS builds to README. (PR #925; thanks @relistan!)
* Add note about using XWayland on Linux. (PR #926)

View File

@ -81,7 +81,7 @@ FreeDVReporterDialog::FreeDVReporterDialog(wxWindow* parent, wxWindowID id, cons
m_listSpots->AssociateModel(spotsDataModel_.get());
auto colObj = m_listSpots->AppendTextColumn(wxT("Callsign"), col++, wxDATAVIEW_CELL_INERT, wxCOL_WIDTH_AUTOSIZE, wxALIGN_CENTER, wxDATAVIEW_COL_RESIZABLE | wxDATAVIEW_COL_SORTABLE);
colObj->GetRenderer()->SetAlignment(wxALIGN_LEFT);
colObj->GetRenderer()->SetAlignment(wxALIGN_LEFT | wxALIGN_CENTRE_VERTICAL);
colObj->GetRenderer()->DisableEllipsize();
colObj->SetMinWidth(70);
if ((col - 1) == wxGetApp().appConfiguration.reporterWindowCurrentSort)
@ -91,7 +91,7 @@ FreeDVReporterDialog::FreeDVReporterDialog(wxWindow* parent, wxWindowID id, cons
colObj = m_listSpots->AppendTextColumn(wxT("Locator"), col++, wxDATAVIEW_CELL_INERT, wxCOL_WIDTH_AUTOSIZE, wxALIGN_CENTER, wxDATAVIEW_COL_RESIZABLE | wxDATAVIEW_COL_SORTABLE);
colObj->GetRenderer()->DisableEllipsize();
colObj->GetRenderer()->SetAlignment(wxALIGN_LEFT);
colObj->GetRenderer()->SetAlignment(wxALIGN_LEFT | wxALIGN_CENTRE_VERTICAL);
colObj->SetMinWidth(65);
if ((col - 1) == wxGetApp().appConfiguration.reporterWindowCurrentSort)
{
@ -100,7 +100,7 @@ FreeDVReporterDialog::FreeDVReporterDialog(wxWindow* parent, wxWindowID id, cons
colObj = m_listSpots->AppendTextColumn(wxT("km"), col++, wxDATAVIEW_CELL_INERT, wxCOL_WIDTH_AUTOSIZE, wxALIGN_CENTER, wxDATAVIEW_COL_RESIZABLE | wxDATAVIEW_COL_SORTABLE);
colObj->GetRenderer()->DisableEllipsize();
colObj->GetRenderer()->SetAlignment(wxALIGN_RIGHT);
colObj->GetRenderer()->SetAlignment(wxALIGN_RIGHT | wxALIGN_CENTRE_VERTICAL);
colObj->SetMinWidth(60);
if ((col - 1) == wxGetApp().appConfiguration.reporterWindowCurrentSort)
{
@ -109,7 +109,7 @@ FreeDVReporterDialog::FreeDVReporterDialog(wxWindow* parent, wxWindowID id, cons
colObj = m_listSpots->AppendTextColumn(wxT("Hdg"), col++, wxDATAVIEW_CELL_INERT, wxCOL_WIDTH_AUTOSIZE, wxALIGN_CENTER, wxDATAVIEW_COL_RESIZABLE | wxDATAVIEW_COL_SORTABLE);
colObj->GetRenderer()->DisableEllipsize();
colObj->GetRenderer()->SetAlignment(wxALIGN_RIGHT);
colObj->GetRenderer()->SetAlignment(wxALIGN_RIGHT | wxALIGN_CENTRE_VERTICAL);
colObj->SetMinWidth(60);
if ((col - 1) == wxGetApp().appConfiguration.reporterWindowCurrentSort)
{
@ -118,7 +118,7 @@ FreeDVReporterDialog::FreeDVReporterDialog(wxWindow* parent, wxWindowID id, cons
colObj = m_listSpots->AppendTextColumn(wxT("Version"), col++, wxDATAVIEW_CELL_INERT, wxCOL_WIDTH_AUTOSIZE, wxALIGN_CENTER, wxDATAVIEW_COL_RESIZABLE | wxDATAVIEW_COL_SORTABLE);
colObj->GetRenderer()->DisableEllipsize();
colObj->GetRenderer()->SetAlignment(wxALIGN_LEFT);
colObj->GetRenderer()->SetAlignment(wxALIGN_LEFT | wxALIGN_CENTRE_VERTICAL);
colObj->SetMinWidth(70);
if ((col - 1) == wxGetApp().appConfiguration.reporterWindowCurrentSort)
{
@ -129,7 +129,7 @@ FreeDVReporterDialog::FreeDVReporterDialog(wxWindow* parent, wxWindowID id, cons
wxGetApp().appConfiguration.reportingConfiguration.reportingFrequencyAsKhz ? wxT("kHz") : wxT("MHz"),
col++, wxDATAVIEW_CELL_INERT, wxCOL_WIDTH_AUTOSIZE, wxALIGN_CENTER, wxDATAVIEW_COL_RESIZABLE | wxDATAVIEW_COL_SORTABLE);
colObj->GetRenderer()->DisableEllipsize();
colObj->GetRenderer()->SetAlignment(wxALIGN_RIGHT);
colObj->GetRenderer()->SetAlignment(wxALIGN_RIGHT | wxALIGN_CENTRE_VERTICAL);
colObj->SetMinWidth(60);
if ((col - 1) == wxGetApp().appConfiguration.reporterWindowCurrentSort)
{
@ -138,7 +138,7 @@ FreeDVReporterDialog::FreeDVReporterDialog(wxWindow* parent, wxWindowID id, cons
colObj = m_listSpots->AppendTextColumn(wxT("Mode"), col++, wxDATAVIEW_CELL_INERT, wxCOL_WIDTH_AUTOSIZE, wxALIGN_CENTER, wxDATAVIEW_COL_RESIZABLE | wxDATAVIEW_COL_SORTABLE);
colObj->GetRenderer()->DisableEllipsize();
colObj->GetRenderer()->SetAlignment(wxALIGN_LEFT);
colObj->GetRenderer()->SetAlignment(wxALIGN_LEFT | wxALIGN_CENTRE_VERTICAL);
colObj->SetMinWidth(65);
if ((col - 1) == wxGetApp().appConfiguration.reporterWindowCurrentSort)
{
@ -147,7 +147,7 @@ FreeDVReporterDialog::FreeDVReporterDialog(wxWindow* parent, wxWindowID id, cons
colObj = m_listSpots->AppendTextColumn(wxT("Status"), col++, wxDATAVIEW_CELL_INERT, wxCOL_WIDTH_AUTOSIZE, wxALIGN_CENTER, wxDATAVIEW_COL_RESIZABLE | wxDATAVIEW_COL_SORTABLE);
colObj->GetRenderer()->DisableEllipsize();
colObj->GetRenderer()->SetAlignment(wxALIGN_LEFT);
colObj->GetRenderer()->SetAlignment(wxALIGN_LEFT | wxALIGN_CENTRE_VERTICAL);
colObj->SetMinWidth(60);
if ((col - 1) == wxGetApp().appConfiguration.reporterWindowCurrentSort)
{
@ -162,7 +162,7 @@ FreeDVReporterDialog::FreeDVReporterDialog(wxWindow* parent, wxWindowID id, cons
colObj = m_listSpots->AppendTextColumn(wxT("Msg"), col++, wxDATAVIEW_CELL_INERT, wxCOL_WIDTH_DEFAULT, wxALIGN_CENTER, wxDATAVIEW_COL_RESIZABLE | wxDATAVIEW_COL_SORTABLE);
#endif // defined(WIN32)
colObj->GetRenderer()->EnableEllipsize(wxELLIPSIZE_END);
colObj->GetRenderer()->SetAlignment(wxALIGN_LEFT);
colObj->GetRenderer()->SetAlignment(wxALIGN_LEFT | wxALIGN_CENTRE_VERTICAL);
colObj->SetMinWidth(130);
if ((col - 1) == wxGetApp().appConfiguration.reporterWindowCurrentSort)
{
@ -172,7 +172,7 @@ FreeDVReporterDialog::FreeDVReporterDialog(wxWindow* parent, wxWindowID id, cons
colObj = m_listSpots->AppendTextColumn(wxT("Last TX"), col++, wxDATAVIEW_CELL_INERT, wxCOL_WIDTH_AUTOSIZE, wxALIGN_CENTER, wxDATAVIEW_COL_RESIZABLE | wxDATAVIEW_COL_SORTABLE);
colObj->GetRenderer()->DisableEllipsize();
colObj->GetRenderer()->SetAlignment(wxALIGN_LEFT);
colObj->GetRenderer()->SetAlignment(wxALIGN_LEFT | wxALIGN_CENTRE_VERTICAL);
colObj->SetMinWidth(60);
if ((col - 1) == wxGetApp().appConfiguration.reporterWindowCurrentSort)
{
@ -181,7 +181,7 @@ FreeDVReporterDialog::FreeDVReporterDialog(wxWindow* parent, wxWindowID id, cons
colObj = m_listSpots->AppendTextColumn(wxT("RX Call"), col++, wxDATAVIEW_CELL_INERT, wxCOL_WIDTH_AUTOSIZE, wxALIGN_CENTER, wxDATAVIEW_COL_RESIZABLE | wxDATAVIEW_COL_SORTABLE);
colObj->GetRenderer()->DisableEllipsize();
colObj->GetRenderer()->SetAlignment(wxALIGN_LEFT);
colObj->GetRenderer()->SetAlignment(wxALIGN_LEFT | wxALIGN_CENTRE_VERTICAL);
colObj->SetMinWidth(65);
if ((col - 1) == wxGetApp().appConfiguration.reporterWindowCurrentSort)
{
@ -190,7 +190,7 @@ FreeDVReporterDialog::FreeDVReporterDialog(wxWindow* parent, wxWindowID id, cons
colObj = m_listSpots->AppendTextColumn(wxT("Mode"), col++, wxDATAVIEW_CELL_INERT, wxCOL_WIDTH_AUTOSIZE, wxALIGN_CENTER, wxDATAVIEW_COL_RESIZABLE | wxDATAVIEW_COL_SORTABLE);
colObj->GetRenderer()->DisableEllipsize();
colObj->GetRenderer()->SetAlignment(wxALIGN_LEFT);
colObj->GetRenderer()->SetAlignment(wxALIGN_LEFT | wxALIGN_CENTRE_VERTICAL);
colObj->SetMinWidth(60);
if ((col - 1) == wxGetApp().appConfiguration.reporterWindowCurrentSort)
{
@ -199,7 +199,7 @@ FreeDVReporterDialog::FreeDVReporterDialog(wxWindow* parent, wxWindowID id, cons
colObj = m_listSpots->AppendTextColumn(wxT("SNR"), col++, wxDATAVIEW_CELL_INERT, wxCOL_WIDTH_AUTOSIZE, wxALIGN_CENTER, wxDATAVIEW_COL_RESIZABLE | wxDATAVIEW_COL_SORTABLE);
colObj->GetRenderer()->DisableEllipsize();
colObj->GetRenderer()->SetAlignment(wxALIGN_LEFT);
colObj->GetRenderer()->SetAlignment(wxALIGN_LEFT | wxALIGN_CENTRE_VERTICAL);
colObj->SetMinWidth(60);
if ((col - 1) == wxGetApp().appConfiguration.reporterWindowCurrentSort)
{
@ -208,7 +208,7 @@ FreeDVReporterDialog::FreeDVReporterDialog(wxWindow* parent, wxWindowID id, cons
colObj = m_listSpots->AppendTextColumn(wxT("Last Update"), col++, wxDATAVIEW_CELL_INERT, wxCOL_WIDTH_AUTOSIZE, wxALIGN_CENTER, wxDATAVIEW_COL_RESIZABLE | wxDATAVIEW_COL_SORTABLE);
colObj->GetRenderer()->DisableEllipsize();
colObj->GetRenderer()->SetAlignment(wxALIGN_LEFT);
colObj->GetRenderer()->SetAlignment(wxALIGN_LEFT | wxALIGN_CENTRE_VERTICAL);
colObj->SetMinWidth(100);
if ((col - 1) == wxGetApp().appConfiguration.reporterWindowCurrentSort)
{