From 1c462828c060ee02c836e3bd2c6e0da4689b5111 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20=C5=A0tetiar?= Date: Sat, 5 Apr 2025 04:12:19 +0000 Subject: [PATCH] ci: fix pushing of ImageBuilder containers MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Eric reported, that he is having problem with imagebuilder:mediatek-filogic-master. The issue is caused by refactoring of Build Push stage in commit cda8065dc5d8 ("ci: add smoke testing of SDK and IB containers"), where I forget to enable pushing with `push: true` input as the default is `push: false`. So lets fix it by explicitly enabling the push input, while at it unify the Push stage configs. Fixes: #167 Fixes: cda8065dc5d8 ("ci: add smoke testing of SDK and IB containers") Link: https://github.com/openwrt/docker/pull/168 Reported-by: Eric Fahlgren Signed-off-by: Petr Štetiar --- .github/workflows/containers.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/containers.yml b/.github/workflows/containers.yml index 2f965a3..251da41 100644 --- a/.github/workflows/containers.yml +++ b/.github/workflows/containers.yml @@ -222,6 +222,7 @@ jobs: if: github.event_name != 'pull_request' uses: docker/build-push-action@v6 with: + push: true no-cache: true tags: ${{ steps.meta.outputs.tags }} labels: ${{ steps.meta.outputs.labels }} @@ -370,10 +371,11 @@ jobs: ' - name: Push + if: github.event_name != 'pull_request' uses: docker/build-push-action@v6 with: + push: true no-cache: true - push: ${{ github.event_name != 'pull_request' }} tags: | ${{ steps.meta_ref.outputs.tags }} ${{ steps.meta_version.outputs.tags }}