diff --git a/CWIdTX.cpp b/CWIdTX.cpp index 2019d2b..189e774 100644 --- a/CWIdTX.cpp +++ b/CWIdTX.cpp @@ -17,8 +17,6 @@ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -// #define WANT_DEBUG - #include "Config.h" #include "Globals.h" #include "CWIdTX.h" diff --git a/DMRDMORX.cpp b/DMRDMORX.cpp index 1da0d89..2c3bdef 100644 --- a/DMRDMORX.cpp +++ b/DMRDMORX.cpp @@ -16,8 +16,6 @@ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -#define WANT_DEBUG - #include "Config.h" #include "Globals.h" #include "DMRDMORX.h" diff --git a/DMRDMOTX.cpp b/DMRDMOTX.cpp index 6ce2957..19d55b2 100644 --- a/DMRDMOTX.cpp +++ b/DMRDMOTX.cpp @@ -18,8 +18,6 @@ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -// #define WANT_DEBUG - #include "Config.h" #include "Globals.h" #include "DMRSlotType.h" diff --git a/DMRIdleRX.cpp b/DMRIdleRX.cpp index 74f8912..3d2b5f5 100644 --- a/DMRIdleRX.cpp +++ b/DMRIdleRX.cpp @@ -16,8 +16,6 @@ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -#define WANT_DEBUG - #include "Config.h" #include "Globals.h" #include "DMRIdleRX.h" diff --git a/DMRSlotRX.cpp b/DMRSlotRX.cpp index a26aee2..0d34560 100644 --- a/DMRSlotRX.cpp +++ b/DMRSlotRX.cpp @@ -16,8 +16,6 @@ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -#define WANT_DEBUG - #include "Config.h" #include "Globals.h" #include "DMRSlotRX.h" diff --git a/DMRTX.cpp b/DMRTX.cpp index fd719c0..aa25bfd 100644 --- a/DMRTX.cpp +++ b/DMRTX.cpp @@ -18,8 +18,6 @@ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -// #define WANT_DEBUG - #include "Config.h" #include "Globals.h" #include "DMRSlotType.h" diff --git a/DStarRX.cpp b/DStarRX.cpp index 38ebe09..6c4f342 100644 --- a/DStarRX.cpp +++ b/DStarRX.cpp @@ -17,8 +17,6 @@ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -// #define WANT_DEBUG - #include "Config.h" #include "Globals.h" #include "DStarRX.h" @@ -439,12 +437,11 @@ void CDStarRX::processData(bool bit) bool syncSeen = false; if (m_dataBits >= SYNC_SCAN_START && m_dataBits <= (SYNC_POS + 1U)) { if (countBits32((m_patternBuffer & DATA_SYNC_MASK) ^ DATA_SYNC_DATA) <= DATA_SYNC_ERRS) { -#if defined(WANT_DEBUG) if (m_dataBits < SYNC_POS) DEBUG2("DStarRX: found data sync in Data, early", SYNC_POS - m_dataBits); else DEBUG1("DStarRX: found data sync in Data"); -#endif + m_rxBufferBits = DSTAR_DATA_LENGTH_BITS; m_dataBits = 0U; syncSeen = true; diff --git a/DStarTX.cpp b/DStarTX.cpp index 865738b..ec0bc9f 100644 --- a/DStarTX.cpp +++ b/DStarTX.cpp @@ -17,8 +17,6 @@ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -#define WANT_DEBUG - #include "Config.h" #include "Globals.h" #include "DStarTX.h" diff --git a/Debug.h b/Debug.h index 667856d..e8be149 100644 --- a/Debug.h +++ b/Debug.h @@ -1,5 +1,5 @@ /* - * Copyright (C) 2015,2016 by Jonathan Naylor G4KLX + * Copyright (C) 2015,2016,2017 by Jonathan Naylor G4KLX * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -20,9 +20,6 @@ #define DEBUG_H #include "Config.h" - -#if defined(WANT_DEBUG) - #include "Globals.h" #define DEBUG1(a) serial.writeDebug((a)) @@ -32,16 +29,5 @@ #define DEBUG5(a,b,c,d,e) serial.writeDebug((a),(b),(c),(d),(e)) #define ASSERT(a) serial.writeAssert((a),#a,__FILE__,__LINE__) -#else - -#define DEBUG1(a) -#define DEBUG2(a,b) -#define DEBUG3(a,b,c) -#define DEBUG4(a,b,c,d) -#define DEBUG5(a,b,c,d,e) -#define ASSERT(a) - -#endif - #endif diff --git a/IO.cpp b/IO.cpp index 22163d9..47ecff2 100644 --- a/IO.cpp +++ b/IO.cpp @@ -18,8 +18,6 @@ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -// #define WANT_DEBUG - #include "Config.h" #include "Globals.h" #include "IO.h" @@ -346,11 +344,6 @@ void CIO::getOverflow(bool& adcOverflow, bool& dacOverflow) adcOverflow = m_adcOverflow > 0U; dacOverflow = m_dacOverflow > 0U; -#if defined(WANT_DEBUG) - if (m_adcOverflow > 0U || m_dacOverflow > 0U) - DEBUG3("IO: adc/dac", m_adcOverflow, m_dacOverflow); -#endif - m_adcOverflow = 0U; m_dacOverflow = 0U; } diff --git a/P25RX.cpp b/P25RX.cpp index 616fd1c..9228c5b 100644 --- a/P25RX.cpp +++ b/P25RX.cpp @@ -16,8 +16,6 @@ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -#define WANT_DEBUG - #include "Config.h" #include "Globals.h" #include "P25RX.h" diff --git a/P25TX.cpp b/P25TX.cpp index a762fa9..e53e363 100644 --- a/P25TX.cpp +++ b/P25TX.cpp @@ -17,8 +17,6 @@ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -// #define WANT_DEBUG - #include "Config.h" #include "Globals.h" #include "P25TX.h" diff --git a/SerialPort.cpp b/SerialPort.cpp index 09c6979..c54b646 100644 --- a/SerialPort.cpp +++ b/SerialPort.cpp @@ -17,8 +17,6 @@ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -// #define WANT_DEBUG - #include "Config.h" #include "Globals.h" @@ -94,7 +92,8 @@ const uint8_t PROTOCOL_VERSION = 1U; CSerialPort::CSerialPort() : m_buffer(), m_ptr(0U), -m_len(0U) +m_len(0U), +m_debug(false) { } @@ -230,6 +229,8 @@ uint8_t CSerialPort::setConfig(const uint8_t* data, uint8_t length) bool ysfLoDev = (data[0U] & 0x08U) == 0x08U; bool simplex = (data[0U] & 0x80U) == 0x80U; + m_debug = (data[0U] & 0x10U) == 0x10U; + bool dstarEnable = (data[1U] & 0x01U) == 0x01U; bool dmrEnable = (data[1U] & 0x02U) == 0x02U; bool ysfEnable = (data[1U] & 0x04U) == 0x04U; @@ -931,6 +932,9 @@ void CSerialPort::writeRSSIData(const uint8_t* data, uint8_t length) void CSerialPort::writeDebug(const char* text) { + if (!m_debug) + return; + uint8_t reply[130U]; reply[0U] = MMDVM_FRAME_START; @@ -948,6 +952,9 @@ void CSerialPort::writeDebug(const char* text) void CSerialPort::writeDebug(const char* text, int16_t n1) { + if (!m_debug) + return; + uint8_t reply[130U]; reply[0U] = MMDVM_FRAME_START; @@ -968,6 +975,9 @@ void CSerialPort::writeDebug(const char* text, int16_t n1) void CSerialPort::writeDebug(const char* text, int16_t n1, int16_t n2) { + if (!m_debug) + return; + uint8_t reply[130U]; reply[0U] = MMDVM_FRAME_START; @@ -991,6 +1001,9 @@ void CSerialPort::writeDebug(const char* text, int16_t n1, int16_t n2) void CSerialPort::writeDebug(const char* text, int16_t n1, int16_t n2, int16_t n3) { + if (!m_debug) + return; + uint8_t reply[130U]; reply[0U] = MMDVM_FRAME_START; @@ -1017,6 +1030,9 @@ void CSerialPort::writeDebug(const char* text, int16_t n1, int16_t n2, int16_t n void CSerialPort::writeDebug(const char* text, int16_t n1, int16_t n2, int16_t n3, int16_t n4) { + if (!m_debug) + return; + uint8_t reply[130U]; reply[0U] = MMDVM_FRAME_START; diff --git a/SerialPort.h b/SerialPort.h index c856ffa..8dc7658 100644 --- a/SerialPort.h +++ b/SerialPort.h @@ -61,6 +61,7 @@ private: uint8_t m_buffer[256U]; uint8_t m_ptr; uint8_t m_len; + bool m_debug; void sendACK(); void sendNAK(uint8_t err); diff --git a/YSFRX.cpp b/YSFRX.cpp index 8a283b1..88c6f83 100644 --- a/YSFRX.cpp +++ b/YSFRX.cpp @@ -16,8 +16,6 @@ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -#define WANT_DEBUG - #include "Config.h" #include "Globals.h" #include "YSFRX.h" diff --git a/YSFTX.cpp b/YSFTX.cpp index b768aed..7c771e3 100644 --- a/YSFTX.cpp +++ b/YSFTX.cpp @@ -17,8 +17,6 @@ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ -// #define WANT_DEBUG - #include "Config.h" #include "Globals.h" #include "YSFTX.h"