From f65022500d4d56045633dbe3121d252010abe4e3 Mon Sep 17 00:00:00 2001 From: Isis Lovecruft Date: Mon, 27 May 2013 07:19:40 +0000 Subject: [PATCH] Add note on using itertools.dropwhile() for efficiency in _is_allowed(). * If/when it's rewritten, a simple speed/efficiency check can be done with: >>> import dis >>> dis.dis(_is_allowed_orig('--dragons')) >>> dis.dis(_is_allowed_orig('--encrypt')) >>> dis.dis(_is_allowed_new('--dragons')) >>> dis.dis(_is_allowed_new('--encrypt')) --- src/_parsers.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/_parsers.py b/src/_parsers.py index 8b1ebba..83c4472 100644 --- a/src/_parsers.py +++ b/src/_parsers.py @@ -404,6 +404,7 @@ def _is_allowed(input): hyphenated = _hyphenate(input) else: hyphenated = input + ## xxx we probably want to use itertools.dropwhile here try: assert hyphenated in allowed except AssertionError as ae: