Unsignedio
/
python-gnupg
mirror of https://github.com/markqvist/python-gnupg.git
1
0
Fork 0
Code Issues Releases Wiki Activity

mktime takes local time, not UTC 

GPG signature timestamps are considered UTC, this may cause times to be off
by delta > 1000 in def test_signature_string_verification because it
incorrectly gave gmtime() as an argument to mktime().

Python 2 and 3 docs both say that mktime should have a struct_time argument
"which expresses the time in local time, not UTC". So the test is now using
time.localtime() instead of time.gmtime()
testing/mmn/xrange_replaces_range_in_python3
Mikael Nordfeldth 2013-07-24 17:28:18 +02:00
parent 43191ab4af
commit f80f216625
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gnupg/test/test_gnupg.py
View File

@ -28,7 +28,7 @@ from argparse import ArgumentParser
from codecs import open as open from codecs import open as open
from functools import wraps from functools import wraps
from glob import glob from glob import glob
from time import gmtime from time import localtime
from time import mktime from time import mktime
import encodings import encodings
@ -645,7 +645,7 @@ class GPGTestCase(unittest.TestCase):
message += '[hackers in popular culture] to push for more power' message += '[hackers in popular culture] to push for more power'
sig = self.gpg.sign(message, default_key=key.fingerprint, sig = self.gpg.sign(message, default_key=key.fingerprint,
passphrase='bruceschneier') passphrase='bruceschneier')
now = mktime(gmtime()) now = mktime(localtime())
self.assertTrue(sig, "Good passphrase should succeed") self.assertTrue(sig, "Good passphrase should succeed")
verified = self.gpg.verify(sig.data) verified = self.gpg.verify(sig.data)
self.assertIsNotNone(verified.fingerprint) self.assertIsNotNone(verified.fingerprint)