This code was broken: Half of it required `options` to be a string, and the
other half required `options` to be a list (which the tests enforced, but the
constructor would silently drop for normal-path initialization).
It seems that more modern versions of Python (e.g. 2.7.8), doing:
from __future__ import print_function
print("SIG=%s" % sig)
with some binary data doesn't actually produce a UnicodeDecodeError,
which means that Python2 is slowly getting less retarded. :D
On the downside, we probably shouldn't have been testing for things
which are Python2.x mis-design issues (and not really our fault, nor a
bug in python-gnupg) anyway.
for some reason, the count was accessed as if it was a Storage
instance, and it's not, it behaves as a dictionnary
includes test case that will fail with the original code
* ADD test_encryption_to_filename which checks that encrypt(...,
output='somefilename.gpg') works correctly (when `output` is a string
containing the filename).
This tests for the bug reported in Issue #24.
https://github.com/isislovecruft/python-gnupg/issues/24
* CHANGE unittest test_copy_data_bytesio() to actually check that the output
data matches the original message string given to io.BytesIO().
* REMOVE class test.test_gnupg.ResultStringIO, as it is now not used
anywhere.
* FIXES test_copy_data_bytesio() not actually testing what it was supposed
to.
* CHANGE unittest test_make_args_drop_protected_options() to discover the
path to the GnuPG binary; the discovered path SHOULD be the same as that
which was discovered upon class instantiation.
* FIXES failure in unittest test_make_args_drop_protected_options() which was
caused by the path to the GnuPG binary being hardcoded.
* ADD patches from Mikael Nordfeldth.
* FIXES#14 issues with strcmp in unittests looking for string literals when
Python3 expects byte strings.
* TODO: perhaps there should be a generalized function in
gnupg/test/test_gnupg.py which automatically translates Python2 strings to
b'' strings.
* CLOSES issue #14.
* ADD docs/change-license-emails.txt, which includes email exchanges between
myself and intrigeri, including links to Debian and LEAP mailing lists with
arguments for and against using AGPL for a library.
* CHANGE license header for all files.
* CHANGE LICENSE file and gnupg/copyright.py to use GPLv3+ text.
GPG signature timestamps are considered UTC, this may cause times to be off
by delta > 1000 in def test_signature_string_verification because it
incorrectly gave gmtime() as an argument to mktime().
Python 2 and 3 docs both say that mktime should have a struct_time argument
"which expresses the time in local time, not UTC". So the test is now using
time.localtime() instead of time.gmtime()
Isis Lovecruft
Garrett Robinson
Charles Duffy
Tom Galloway
Antoine Beaupré
drebs
kali
Thomas Tanner
Matt Behrens
Mikael Nordfeldth