JNI/JSSE: add calls to PRIVATE_KEY_LOCK/UNLOCK and FIPS_CAST_ECC_CDH for wolfCrypt FIPS 140-3 compatibility

pull/57/head
Chris Conlon 2023-10-27 14:17:13 -06:00
parent 34125ca403
commit adf00d6409
3 changed files with 51 additions and 7 deletions

View File

@ -208,7 +208,9 @@ Java_com_wolfssl_wolfcrypt_Dh_wc_1DhGenerateKeyPair(
} }
XMEMSET(pub, 0, pubSz); XMEMSET(pub, 0, pubSz);
PRIVATE_KEY_UNLOCK();
ret = wc_DhGenerateKeyPair(key, rng, priv, &privSz, pub, &pubSz); ret = wc_DhGenerateKeyPair(key, rng, priv, &privSz, pub, &pubSz);
PRIVATE_KEY_LOCK();
} }
if (ret == 0) { if (ret == 0) {
@ -367,7 +369,9 @@ Java_com_wolfssl_wolfcrypt_Dh_wc_1DhAgree(
ret = BAD_FUNC_ARG; ret = BAD_FUNC_ARG;
} }
else { else {
PRIVATE_KEY_UNLOCK();
ret = wc_DhAgree(key, secret, &secretSz, priv, privSz, pub, pubSz); ret = wc_DhAgree(key, secret, &secretSz, priv, privSz, pub, pubSz);
PRIVATE_KEY_LOCK();
} }
if (ret == 0) { if (ret == 0) {

View File

@ -434,7 +434,9 @@ Java_com_wolfssl_wolfcrypt_Ecc_wc_1ecc_1export_1x963(
/* get size */ /* get size */
if (ret == 0) { if (ret == 0) {
PRIVATE_KEY_UNLOCK();
ret = wc_ecc_export_x963(ecc, NULL, &outputSz); ret = wc_ecc_export_x963(ecc, NULL, &outputSz);
PRIVATE_KEY_LOCK();
if (ret == LENGTH_ONLY_E) { if (ret == LENGTH_ONLY_E) {
ret = 0; ret = 0;
} }
@ -451,7 +453,9 @@ Java_com_wolfssl_wolfcrypt_Ecc_wc_1ecc_1export_1x963(
} }
if (ret == 0) { if (ret == 0) {
PRIVATE_KEY_UNLOCK();
ret = wc_ecc_export_x963(ecc, output, &outputSz); ret = wc_ecc_export_x963(ecc, output, &outputSz);
PRIVATE_KEY_LOCK();
} }
if (ret == 0) { if (ret == 0) {
@ -771,7 +775,9 @@ Java_com_wolfssl_wolfcrypt_Ecc_wc_1ecc_1shared_1secret(
#endif #endif
if (ret == 0) { if (ret == 0) {
PRIVATE_KEY_UNLOCK();
ret = wc_ecc_shared_secret(ecc, pub, output, &outputSz); ret = wc_ecc_shared_secret(ecc, pub, output, &outputSz);
PRIVATE_KEY_LOCK();
} }
if (ret == 0) { if (ret == 0) {

View File

@ -52,85 +52,118 @@ JNIEXPORT jint JNICALL Java_com_wolfssl_wolfcrypt_WolfObject_init
#if defined(HAVE_FIPS) && defined(HAVE_FIPS_VERSION) && (HAVE_FIPS_VERSION == 5) #if defined(HAVE_FIPS) && defined(HAVE_FIPS_VERSION) && (HAVE_FIPS_VERSION == 5)
/* run FIPS 140-3 conditional algorithm self tests early to prevent /* run FIPS 140-3 conditional algorithm self tests early to prevent
* multi threaded issues later on */ * multi threaded issues later on */
#if !defined(NO_AES) && !defined(NO_AES_CBC)
if (ret == 0) { if (ret == 0) {
ret = wc_RunCast_fips(FIPS_CAST_AES_CBC); ret = wc_RunCast_fips(FIPS_CAST_AES_CBC);
if (ret != 0) { if (ret != 0) {
printf("AES-CBC CAST failed"); printf("AES-CBC CAST failed");
} }
} }
#endif
#ifdef HAVE_AESGCM
if (ret == 0) { if (ret == 0) {
ret = wc_RunCast_fips(FIPS_CAST_AES_GCM); ret = wc_RunCast_fips(FIPS_CAST_AES_GCM);
if (ret != 0) { if (ret != 0) {
printf("AES-GCM CAST failed"); printf("AES-GCM CAST failed");
} }
} }
#endif
#ifndef NO_SHA
if (ret == 0) { if (ret == 0) {
ret = wc_RunCast_fips(FIPS_CAST_HMAC_SHA1); ret = wc_RunCast_fips(FIPS_CAST_HMAC_SHA1);
if (ret != 0) { if (ret != 0) {
printf("HMAC-SHA1 CAST failed"); printf("HMAC-SHA1 CAST failed");
} }
} }
#endif
/* the only non-optional CAST */
if (ret == 0) { if (ret == 0) {
ret = wc_RunCast_fips(FIPS_CAST_HMAC_SHA2_256); ret = wc_RunCast_fips(FIPS_CAST_HMAC_SHA2_256);
if (ret != 0) { if (ret != 0) {
printf("HMAC-SHA2-256 CAST failed"); printf("HMAC-SHA2-256 CAST failed");
} }
} }
#ifdef WOLFSSL_SHA512
if (ret == 0) { if (ret == 0) {
ret = wc_RunCast_fips(FIPS_CAST_HMAC_SHA2_512); ret = wc_RunCast_fips(FIPS_CAST_HMAC_SHA2_512);
if (ret != 0) { if (ret != 0) {
printf("HMAC-SHA2-512 CAST failed"); printf("HMAC-SHA2-512 CAST failed");
} }
} }
#endif
#ifdef WOLFSSL_SHA3
if (ret == 0) { if (ret == 0) {
ret = wc_RunCast_fips(FIPS_CAST_HMAC_SHA3_256); ret = wc_RunCast_fips(FIPS_CAST_HMAC_SHA3_256);
if (ret != 0) { if (ret != 0) {
printf("HMAC-SHA3-256 CAST failed"); printf("HMAC-SHA3-256 CAST failed");
} }
} }
#endif
#ifdef HAVE_HASHDRBG
if (ret == 0) { if (ret == 0) {
ret = wc_RunCast_fips(FIPS_CAST_DRBG); ret = wc_RunCast_fips(FIPS_CAST_DRBG);
if (ret != 0) { if (ret != 0) {
printf("Hash_DRBG CAST failed"); printf("Hash_DRBG CAST failed");
} }
} }
#endif
#ifndef NO_RSA
if (ret == 0) { if (ret == 0) {
ret = wc_RunCast_fips(FIPS_CAST_RSA_SIGN_PKCS1v15); ret = wc_RunCast_fips(FIPS_CAST_RSA_SIGN_PKCS1v15);
if (ret != 0) { if (ret != 0) {
printf("RSA sign CAST failed"); printf("RSA sign CAST failed");
} }
} }
#endif
#if defined(HAVE_ECC_CDH) && defined(HAVE_ECC_CDH_CAST)
if (ret == 0) {
ret = wc_RunCast_fips(FIPS_CAST_ECC_CDH);
if (ret != 0) {
printf("ECC CDH CAST failed");
}
}
#endif
#ifdef HAVE_ECC_DHE
if (ret == 0) { if (ret == 0) {
ret = wc_RunCast_fips(FIPS_CAST_ECC_PRIMITIVE_Z); ret = wc_RunCast_fips(FIPS_CAST_ECC_PRIMITIVE_Z);
if (ret != 0) { if (ret != 0) {
printf("ECC Primitive Z CAST failed"); printf("ECC Primitive Z CAST failed");
} }
} }
if (ret == 0) { #endif
ret = wc_RunCast_fips(FIPS_CAST_DH_PRIMITIVE_Z); #ifdef HAVE_ECC
if (ret != 0) {
printf("DH Primitive Z CAST failed");
}
}
if (ret == 0) { if (ret == 0) {
ret = wc_RunCast_fips(FIPS_CAST_ECDSA); ret = wc_RunCast_fips(FIPS_CAST_ECDSA);
if (ret != 0) { if (ret != 0) {
printf("ECDSA CAST failed"); printf("ECDSA CAST failed");
} }
} }
#endif
#ifndef NO_DH
if (ret == 0) {
ret = wc_RunCast_fips(FIPS_CAST_DH_PRIMITIVE_Z);
if (ret != 0) {
printf("DH Primitive Z CAST failed");
}
}
#endif
#ifdef WOLFSSL_HAVE_PRF
if (ret == 0) { if (ret == 0) {
ret = wc_RunCast_fips(FIPS_CAST_KDF_TLS12); ret = wc_RunCast_fips(FIPS_CAST_KDF_TLS12);
if (ret != 0) { if (ret != 0) {
printf("KDF TLSv1.2 CAST failed"); printf("KDF TLSv1.2 CAST failed");
} }
} }
#endif
#if defined(WOLFSSL_HAVE_PRF) && defined(WOLFSSL_TLS13)
if (ret == 0) { if (ret == 0) {
ret = wc_RunCast_fips(FIPS_CAST_KDF_TLS13); ret = wc_RunCast_fips(FIPS_CAST_KDF_TLS13);
if (ret != 0) { if (ret != 0) {
printf("KDF TLSv1.3 CAST failed"); printf("KDF TLSv1.3 CAST failed");
} }
} }
#endif
#ifdef WOLFSSL_WOLFSSH
if (ret == 0) { if (ret == 0) {
ret = wc_RunCast_fips(FIPS_CAST_KDF_SSH); ret = wc_RunCast_fips(FIPS_CAST_KDF_SSH);
if (ret != 0) { if (ret != 0) {
@ -138,6 +171,7 @@ JNIEXPORT jint JNICALL Java_com_wolfssl_wolfcrypt_WolfObject_init
} }
} }
#endif #endif
#endif /* HAVE_FIPS && HAVE_FIPS_VERSION == 5 */
if (ret < 0) { if (ret < 0) {
return ret; return ret;