WolfSSL
/
wolfcrypt-py
mirror of https://github.com/wolfSSL/wolfcrypt-py.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Resolve comments by Copilot

pull/90/head
Martijn de Milliano 2026-04-10 17:01:13 +02:00
parent 9a10f58601
commit 168498471b
2 changed files with 15 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/test_mldsa.py
View File

@ -135,7 +135,8 @@ if _lib.ML_DSA_ENABLED:
wrong_message = b"This is a wrong message for ML-DSA signature"
assert not mldsa_pub.verify(signature, wrong_message)
# Verify with ctx for signature generated without
# Verify a signature generated without a context but where a context
# is provided during verify
ctx = b"This is a test context for ML-DSA signature"
wrong_ctx = b"This is a wrong context for ML-DSA signature"
assert not mldsa_pub.verify(signature, message, ctx=wrong_ctx)
@ -150,5 +151,8 @@ if _lib.ML_DSA_ENABLED:
# Verify the signature by MlDsaPublic
assert mldsa_pub.verify(signature, message, ctx=ctx)
# Verify with wrong ctx
# Verify but do not provide a context
assert not mldsa_pub.verify(signature, message, ctx=None)
# Verify with wrong context
assert not mldsa_pub.verify(signature, message, ctx=wrong_ctx)

15
wolfcrypt/ciphers.py
View File

@ -2267,7 +2267,7 @@ if _lib.ML_DSA_ENABLED:
:type message: bytes or str
:param rng: random number generator for sign
:type rng: Random
:param ctx: context (optional)
:param ctx: context (optional, maximum 255 bytes)
:type ctx: None for no context, str or bytes otherwise
:return: signature
:rtype: bytes
@ -2280,9 +2280,11 @@ if _lib.ML_DSA_ENABLED:
if ctx is not None:
ctx_bytestype = t2b(ctx)
if len(ctx_bytestype) > 255:
raise ValueError(f"context length {len(ctx_bytestype)} too large: must be 255 bytes or less")
ret = _lib.wc_dilithium_sign_ctx_msg(
_ffi.from_buffer(ctx_bytestype),
len(ctx_bytestype),
len(ctx_bytestype), # length must be < 256 bytes
_ffi.from_buffer(msg_bytestype),
len(msg_bytestype),
signature,
@ -2290,6 +2292,8 @@ if _lib.ML_DSA_ENABLED:
self.native_object,
rng.native_object,
)
if ret < 0: # pragma: no cover
raise WolfCryptError("wc_dilithium_sign_ctx_msg() error (%d)" % ret)
else:
ret = _lib.wc_dilithium_sign_msg(
_ffi.from_buffer(msg_bytestype),
@ -2299,10 +2303,9 @@ if _lib.ML_DSA_ENABLED:
self.native_object,
rng.native_object,
)
if ret < 0: # pragma: no cover
raise WolfCryptError("wc_dilithium_sign_msg() error (%d)" % ret)
if ret < 0: # pragma: no cover
raise WolfCryptError("wc_dilithium_sign_msg() error (%d)" % ret)
if in_size != out_size[0]:
raise WolfCryptError(
"in_size=%d and out_size=%d don't match" % (in_size, out_size[0])