WolfSSL
/
wolfssh
mirror of https://github.com/wolfSSL/wolfssh.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Auth Fix 

Before calling the auth callback, be sure to zero out the UserAuthData
I/O value, in case the calling application doesn't set a password or
key.
pull/164/head
John Safranek 2019-04-26 10:21:14 -07:00
parent e004dfa2b8
commit cd05289772
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/internal.c
View File

@ -6700,6 +6700,7 @@ int SendUserAuthRequest(WOLFSSH* ssh, byte authId)
ret = WS_BAD_ARGUMENT; ret = WS_BAD_ARGUMENT;
if (ret == WS_SUCCESS) { if (ret == WS_SUCCESS) {
WMEMSET(&authData, 0, sizeof(WS_UserAuthData));
if (authId == ID_USERAUTH_PASSWORD && ssh->ctx->userAuthCb != NULL) { if (authId == ID_USERAUTH_PASSWORD && ssh->ctx->userAuthCb != NULL) {
WLOG(WS_LOG_DEBUG, "SUARPW: Calling the userauth callback"); WLOG(WS_LOG_DEBUG, "SUARPW: Calling the userauth callback");
ret = ssh->ctx->userAuthCb(WOLFSSH_USERAUTH_PASSWORD, ret = ssh->ctx->userAuthCb(WOLFSSH_USERAUTH_PASSWORD,
@ -6768,6 +6769,7 @@ int SendUserAuthRequest(WOLFSSH* ssh, byte authId)
if (ret == WS_SUCCESS) if (ret == WS_SUCCESS)
ret = wolfSSH_SendPacket(ssh); ret = wolfSSH_SendPacket(ssh);
ForceZero(&authData, sizeof(WS_UserAuthData));
WLOG(WS_LOG_DEBUG, "Leaving SendUserAuthRequest(), ret = %d", ret); WLOG(WS_LOG_DEBUG, "Leaving SendUserAuthRequest(), ret = %d", ret);
return ret; return ret;
} }