WolfSSL
/
wolfssh
mirror of https://github.com/wolfSSL/wolfssh.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Coverity: Uninitialized scalar variable 

1. Remove the check on authType, it is covered already.
2. Add Keyboard Setup to the existing check on authType.
3. Add a branch for User Auth None so it reaches its handler
   in the map loop rather than the new error case.
4. Add else case for an error.

Fixes CID: 637345
pull/1011/head
John Safranek 2026-01-20 10:01:08 -08:00 committed by Paul Adelsbach
parent 36e276529f
commit d43dfd5b83
1 changed files with 12 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
examples/echoserver/echoserver.c
View File

@ -2293,7 +2293,7 @@ static int wsUserAuth(byte authType,
{
PwMapList* list;
PwMap* map;
byte authHash[WC_SHA256_DIGEST_SIZE];
byte authHash[WC_SHA256_DIGEST_SIZE] = {0};
if (ctx == NULL) {
fprintf(stderr, "wsUserAuth: ctx not set");
@ -2306,19 +2306,6 @@ static int wsUserAuth(byte authType,
return WOLFSSH_USERAUTH_WOULD_BLOCK;
}
if (authType != WOLFSSH_USERAUTH_PASSWORD &&
#ifdef WOLFSSH_ALLOW_USERAUTH_NONE
authType != WOLFSSH_USERAUTH_NONE &&
#endif
#ifdef WOLFSSH_KEYBOARD_INTERACTIVE
authType != WOLFSSH_USERAUTH_KEYBOARD &&
authType != WOLFSSH_USERAUTH_KEYBOARD_SETUP &&
#endif
authType != WOLFSSH_USERAUTH_PUBLICKEY) {
return WOLFSSH_USERAUTH_FAILURE;
}
if (authType == WOLFSSH_USERAUTH_PASSWORD) {
wc_Sha256Hash(authData->sf.password.password,
authData->sf.password.passwordSz,
@ -2333,6 +2320,9 @@ static int wsUserAuth(byte authType,
authData->sf.keyboard.responseLengths[0],
authHash);
}
else if (authType == WOLFSSH_USERAUTH_KEYBOARD_SETUP) {
/* Do nothing. */
}
#endif
else if (authType == WOLFSSH_USERAUTH_PUBLICKEY) {
wc_Sha256Hash(authData->sf.publicKey.publicKey,
@ -2406,6 +2396,14 @@ static int wsUserAuth(byte authType,
}
#endif /* WOLFSSH_CERTS && !WOLFSSH_NO_FPKI */
}
#ifdef WOLFSSH_ALLOW_USERAUTH_NONE
else if (authType == WOLFSSH_USERAUTH_NONE) {
/* Handled in the map loop below. */
}
#endif
else {
return WOLFSSH_USERAUTH_INVALID_AUTHTYPE;
}
list = (PwMapList*)ctx;
map = list->head;