WolfSSL
/
wolfssh
mirror of https://github.com/wolfSSL/wolfssh.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Free ECC key on ParseECCPubKey error paths 

Set keyAllocated right after wc_ecc_init_ex so FreePubKey frees the
initialized key on the early error exits, not only after a
successful import.
pull/1040/head
John Safranek 2026-06-12 11:01:49 -07:00 committed by Paul Adelsbach
parent 85fc81bd41
commit db62bed546
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/internal.c
View File

@ -5067,6 +5067,11 @@ static int ParseECCPubKey(WOLFSSH *ssh,
ret = wc_ecc_init_ex(&sigKeyBlock_ptr->sk.ecc.key, ssh->ctx->heap,
INVALID_DEVID);
if (ret == 0) {
/* The key is initialized. Mark it so that FreePubKey() cleans
* it up on all paths, including the error paths below. */
sigKeyBlock_ptr->keyAllocated = 1;
}
#ifdef HAVE_WC_ECC_SET_RNG
if (ret == 0)
ret = wc_ecc_set_rng(&sigKeyBlock_ptr->sk.ecc.key, ssh->rng);
@ -5135,7 +5140,6 @@ static int ParseECCPubKey(WOLFSSH *ssh,
if (ret == 0) {
sigKeyBlock_ptr->keySz =
(word32)sizeof(sigKeyBlock_ptr->sk.ecc.key);
sigKeyBlock_ptr->keyAllocated = 1;
}
else {
ret = WS_ECC_E;