From 38f2f437051c1d6dc5a014b65d681c65d5a6bee2 Mon Sep 17 00:00:00 2001 From: Andras Fekete Date: Wed, 8 Feb 2023 13:08:12 -0500 Subject: [PATCH 1/2] Fix for calling 'mp_clear(tmp)' without having called 'mp_init(tmp)' --- wolfcrypt/src/dsa.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/wolfcrypt/src/dsa.c b/wolfcrypt/src/dsa.c index bab873603..ac0387c73 100644 --- a/wolfcrypt/src/dsa.c +++ b/wolfcrypt/src/dsa.c @@ -304,6 +304,9 @@ int wc_MakeDsaParameters(WC_RNG *rng, int modulus_size, DsaKey *dsa) if (err == MP_OKAY) #endif + err = mp_init(tmp); + + if (err == MP_OKAY) err = mp_init_multi(tmp2, &dsa->p, &dsa->q, 0, 0, 0); if (err == MP_OKAY) @@ -321,9 +324,6 @@ int wc_MakeDsaParameters(WC_RNG *rng, int modulus_size, DsaKey *dsa) if (err == MP_OKAY) err = mp_add_d(&dsa->p, 1, &dsa->p); - if (err == MP_OKAY) - err = mp_init(tmp); - /* tmp = 2q */ if (err == MP_OKAY) err = mp_add(&dsa->q, &dsa->q, tmp); From 08c63d55dc95a731b40aaeef2c0c250869b5af01 Mon Sep 17 00:00:00 2001 From: Andras Fekete Date: Wed, 8 Feb 2023 13:18:13 -0500 Subject: [PATCH 2/2] Addressing PR comments --- wolfcrypt/src/dsa.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/wolfcrypt/src/dsa.c b/wolfcrypt/src/dsa.c index ac0387c73..d9b4e1c5e 100644 --- a/wolfcrypt/src/dsa.c +++ b/wolfcrypt/src/dsa.c @@ -304,10 +304,7 @@ int wc_MakeDsaParameters(WC_RNG *rng, int modulus_size, DsaKey *dsa) if (err == MP_OKAY) #endif - err = mp_init(tmp); - - if (err == MP_OKAY) - err = mp_init_multi(tmp2, &dsa->p, &dsa->q, 0, 0, 0); + err = mp_init_multi(tmp, tmp2, &dsa->p, &dsa->q, 0, 0); if (err == MP_OKAY) err = mp_read_unsigned_bin(tmp2, buf, msize - qsize);