WolfSSL
/
wolfssl
mirror of https://github.com/wolfSSL/wolfssl.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Merge pull request #8784 from rlm2002/coverity 

coverity: init dgst variable test_sha3.c and issues in api.c
pull/8795/head
Sean Parkinson 2025-05-22 08:34:11 +10:00 committed by GitHub
parent 005ce08380 a170624118
commit 2398a94cf8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tests/api.c
View File

@ -38948,12 +38948,14 @@ static int test_wolfSSL_d2i_PrivateKeys_bio(void)
{ {
XFILE file = XBADFILE; XFILE file = XBADFILE;
const char* fname = "./certs/ecc-key.der"; const char* fname = "./certs/ecc-key.der";
long lsz = 0;
size_t sz = 0; size_t sz = 0;
byte* buf = NULL; byte* buf = NULL;
ExpectTrue((file = XFOPEN(fname, "rb")) != XBADFILE); ExpectTrue((file = XFOPEN(fname, "rb")) != XBADFILE);
ExpectTrue(XFSEEK(file, 0, XSEEK_END) == 0); ExpectTrue(XFSEEK(file, 0, XSEEK_END) == 0);
ExpectTrue((sz = XFTELL(file)) != 0); ExpectTrue((lsz = XFTELL(file)) > 0);
sz = (size_t)lsz;
ExpectTrue(XFSEEK(file, 0, XSEEK_SET) == 0); ExpectTrue(XFSEEK(file, 0, XSEEK_SET) == 0);
ExpectNotNull(buf = (byte*)XMALLOC(sz, HEAP_HINT, DYNAMIC_TYPE_FILE)); ExpectNotNull(buf = (byte*)XMALLOC(sz, HEAP_HINT, DYNAMIC_TYPE_FILE));
ExpectIntEQ(XFREAD(buf, 1, sz, file), sz); ExpectIntEQ(XFREAD(buf, 1, sz, file), sz);
@ -52361,6 +52363,7 @@ static int test_wolfSSL_RSA_verify(void)
SHA256_CTX c; SHA256_CTX c;
EVP_PKEY *evpPkey = NULL; EVP_PKEY *evpPkey = NULL;
EVP_PKEY *evpPubkey = NULL; EVP_PKEY *evpPubkey = NULL;
long lsz = 0;
size_t sz; size_t sz;
/* generate hash */ /* generate hash */
@ -52372,10 +52375,11 @@ static int test_wolfSSL_RSA_verify(void)
wc_Sha256Free((wc_Sha256*)&c); wc_Sha256Free((wc_Sha256*)&c);
#endif #endif
/* read privete key file */ /* read private key file */
ExpectTrue((fp = XFOPEN(svrKeyFile, "rb")) != XBADFILE); ExpectTrue((fp = XFOPEN(svrKeyFile, "rb")) != XBADFILE);
ExpectIntEQ(XFSEEK(fp, 0, XSEEK_END), 0); ExpectIntEQ(XFSEEK(fp, 0, XSEEK_END), 0);
ExpectTrue((sz = XFTELL(fp)) > 0); ExpectTrue((lsz = XFTELL(fp)) > 0);
sz = (size_t)lsz;
ExpectIntEQ(XFSEEK(fp, 0, XSEEK_SET), 0); ExpectIntEQ(XFSEEK(fp, 0, XSEEK_SET), 0);
ExpectNotNull(buf = (byte*)XMALLOC(sz, NULL, DYNAMIC_TYPE_FILE)); ExpectNotNull(buf = (byte*)XMALLOC(sz, NULL, DYNAMIC_TYPE_FILE));
ExpectIntEQ(XFREAD(buf, 1, sz, fp), sz); ExpectIntEQ(XFREAD(buf, 1, sz, fp), sz);
@ -54544,7 +54548,7 @@ static int test_wolfSSL_PEM_read_bio_ECPKParameters(void)
ExpectNotNull(bio = BIO_new_mem_buf((unsigned char*)ec_nc_p384, ExpectNotNull(bio = BIO_new_mem_buf((unsigned char*)ec_nc_p384,
sizeof(ec_nc_p384))); sizeof(ec_nc_p384)));
ExpectNotNull(ret = PEM_read_bio_ECPKParameters(bio, &group, NULL, NULL)); ExpectNotNull(ret = PEM_read_bio_ECPKParameters(bio, &group, NULL, NULL));
ExpectIntEQ(group == ret, 1); ExpectIntEQ(ret == group, 1);
ExpectIntEQ(EC_GROUP_get_curve_name(group), NID_secp384r1); ExpectIntEQ(EC_GROUP_get_curve_name(group), NID_secp384r1);
BIO_free(bio); BIO_free(bio);
bio = NULL; bio = NULL;

1
tests/api/test_digest.h
View File

@ -788,6 +788,7 @@ do { \
type dgst_copy; \ type dgst_copy; \
word32 flags; \ word32 flags; \
\ \
XMEMSET(&dgst, 0, sizeof(dgst)); \
XMEMSET(&dgst_copy, 0, sizeof(dgst_copy)); \ XMEMSET(&dgst_copy, 0, sizeof(dgst_copy)); \
ExpectIntEQ(wc_Init##inst(&dgst, HEAP_HINT, INVALID_DEVID), 0); \ ExpectIntEQ(wc_Init##inst(&dgst, HEAP_HINT, INVALID_DEVID), 0); \
\ \