WolfSSL
/
wolfssl
mirror of https://github.com/wolfSSL/wolfssl.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Merge pull request #707 from JacobBarthelmeh/master 

fix location in tfm.c that could result in potential cache attack
pull/711/head
toddouska 2017-01-11 12:35:22 -08:00 committed by GitHub
parent 8954de40ff e3277c19b7
commit 575ac7b9d3
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
wolfcrypt/src/tfm.c
View File

@ -480,12 +480,11 @@ void fp_mul_comba(fp_int *A, fp_int *B, fp_int *C)
pa = FP_SIZE-1; pa = FP_SIZE-1;
} }
if (A == C || B == C) { /* Always take branch to use tmp variable. This avoids a cache attack for
* determining if C equals A */
if (1) {
fp_init(&tmp); fp_init(&tmp);
dst = &tmp; dst = &tmp;
} else {
fp_zero(C);
dst = C;
} }
for (ix = 0; ix < pa; ix++) { for (ix = 0; ix < pa; ix++) {