1. Added a missed attr files for the OSCP status files. Bare minimum attr.
2. Added the attr files to the automake include.
3. Fix out of bounds read with the OCSP URL.
pull/1737/head
John Safranek 2018-08-02 14:50:59 -07:00
parent c71f730d67
commit 5ae45436f4
3 changed files with 8 additions and 2 deletions

View File

@ -4,9 +4,13 @@
EXTRA_DIST += \
certs/ocsp/index-ca-and-intermediate-cas.txt \
certs/ocsp/index-ca-and-intermediate-cas.txt.attr \
certs/ocsp/index-intermediate1-ca-issued-certs.txt \
certs/ocsp/index-intermediate1-ca-issued-certs.txt.attr \
certs/ocsp/index-intermediate2-ca-issued-certs.txt \
certs/ocsp/index-intermediate2-ca-issued-certs.txt.attr \
certs/ocsp/index-intermediate3-ca-issued-certs.txt \
certs/ocsp/index-intermediate3-ca-issued-certs.txt \
certs/ocsp/index-intermediate3-ca-issued-certs.txt.attr \
certs/ocsp/openssl.cnf \
certs/ocsp/intermediate1-ca-key.pem \
certs/ocsp/intermediate1-ca-cert.pem \

View File

@ -0,0 +1 @@
unique_subject = no

View File

@ -13351,7 +13351,7 @@ int InitOcspRequest(OcspRequest* req, DecodedCert* cert, byte useNonce,
req->serialSz = cert->serialSz;
if (cert->extAuthInfoSz != 0 && cert->extAuthInfo != NULL) {
req->url = (byte*)XMALLOC(cert->extAuthInfoSz, req->heap,
req->url = (byte*)XMALLOC(cert->extAuthInfoSz + 1, req->heap,
DYNAMIC_TYPE_OCSP_REQUEST);
if (req->url == NULL) {
XFREE(req->serial, req->heap, DYNAMIC_TYPE_OCSP);
@ -13360,6 +13360,7 @@ int InitOcspRequest(OcspRequest* req, DecodedCert* cert, byte useNonce,
XMEMCPY(req->url, cert->extAuthInfo, cert->extAuthInfoSz);
req->urlSz = cert->extAuthInfoSz;
req->url[req->urlSz] = 0;
}
}