From 69bc801c13358b285bd741235207b252cee2489c Mon Sep 17 00:00:00 2001 From: Daniel Pouzzner Date: Mon, 18 Oct 2021 16:20:34 -0500 Subject: [PATCH] scan-build LLVM-13 fixes: src/ssl.c: work around deadcode.DeadStores warning in wolfSSL_X509_REQ_sign() in a different way, avoiding WC_MAYBE_UNUSED. --- src/ssl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ssl.c b/src/ssl.c index 1014a826f..7b7e9879d 100644 --- a/src/ssl.c +++ b/src/ssl.c @@ -54614,7 +54614,7 @@ void wolfSSL_X509_REQ_free(WOLFSSL_X509* req) int wolfSSL_X509_REQ_sign(WOLFSSL_X509 *req, WOLFSSL_EVP_PKEY *pkey, const WOLFSSL_EVP_MD *md) { - WC_MAYBE_UNUSED int ret; + int ret; byte der[2048]; int derSz = sizeof(der); @@ -54625,8 +54625,8 @@ int wolfSSL_X509_REQ_sign(WOLFSSL_X509 *req, WOLFSSL_EVP_PKEY *pkey, /* Create a Cert that has the certificate request fields. */ req->sigOID = wolfSSL_sigTypeFromPKEY((WOLFSSL_EVP_MD*)md, pkey); - if ((ret = wolfssl_x509_make_der(req, 1, der, &derSz, 0)) - != WOLFSSL_SUCCESS) { + ret = wolfssl_x509_make_der(req, 1, der, &derSz, 0); + if (ret != WOLFSSL_SUCCESS) { WOLFSSL_MSG("Unable to make DER for X509"); WOLFSSL_LEAVE("wolfSSL_X509_REQ_sign", ret); return WOLFSSL_FAILURE;