WolfSSL
/
wolfssl
mirror of https://github.com/wolfSSL/wolfssl.git
1
0
Fork 0
Code Issues Releases Wiki Activity

tests: compare forgery packets field by field, not as raw memory

pull/11355/head
Daniele Lacamera 2026-09-11 16:59:32 +02:00
parent d64c1d295a
commit 80472790e3
1 changed files with 28 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
tests/api/test_dtls.c
View File

@ -9278,6 +9278,33 @@ static void df_parse(DfPkt* p)
/* ------------------------------------------------------------ IO callbacks */
/* Field by field, not one XMEMCMP over the whole DfPkt: the struct mixes byte
* and word16 members after a run of ints, so it carries padding and has no
* unique object representation. Comparing it as raw memory reads those padding
* bytes -- which is what bugprone-suspicious-memory-comparison rejects, and
* they carry no meaning anyway. Only data[] up to the declared length matters.
*/
static int df_pkt_differs(const DfPkt* a, const DfPkt* b)
{
int n;
if (a->len != b->len || a->toServer != b->toServer || a->idx != b->idx ||
a->hold != b->hold || a->taken != b->taken ||
a->type != b->type || a->epoch != b->epoch ||
a->hsType != b->hsType || a->msgSeq != b->msgSeq) {
return 1;
}
n = a->len;
if (n < 0) {
n = 0;
}
if (n > DF_MAX_SZ) {
n = DF_MAX_SZ;
}
return XMEMCMP(a->data, b->data, (size_t)n) != 0;
}
static int df_send(WOLFSSL* ssl, char* buf, int sz, void* ctx)
{
DfCtx* c = (DfCtx*)ctx;
@ -9313,7 +9340,7 @@ static int df_send(WOLFSSL* ssl, char* buf, int sz, void* ctx)
/* Both halves are needed: a policy that edits bytes changes the packet
* and touches no counter, while one that replays or drops leaves the
* packet alone and moves a counter. */
if (XMEMCMP(&before, p, sizeof(before)) != 0 ||
if (df_pkt_differs(&before, p) ||
c->nDrop + c->nDup + c->nMod + c->nHold + c->nCoalesce != acted)
df_mutations++;
}