From b8b13ad9e9d7d0e5c55635e85e0d4bb4db38a660 Mon Sep 17 00:00:00 2001 From: Jay Satiro Date: Wed, 1 Apr 2015 02:05:15 -0400 Subject: [PATCH] build: Revert using MSBuild property files to auto-detect platform toolset Prior to this change I had added a .props file for each .vcxproj to use MSBuild's $(DefaultPlatformToolset) as the the default for $(PlatformToolset). Typically that configuration allows for the appropriate toolset to be used no matter which version of VS2010+ the wolfssl64.sln and project files are opened in. Problem is when an MSBuild was used from the command line to build the solution it got the $(DefaultPlatformToolset) from a property file based on the solution header (currently "Format Version 12.00" which maps to Visual Studio 2012) instead. Another side effect was it set the VisualStudioVersion to 11.0 (n - 1; n in this case 12.0) which was incorrect. To remedy the above this change reverts back to the old PlatformToolset method where the v110 toolset (Visual Studio 2012) is specified in every configuration in every vcxproj. The user will have to specify explicitly a different toolset to override it (either via command line or the GUI) if they are not using VS2012. VS2010 example: msbuild -p:Configuration="Debug" wolfssl64.sln -p:PlatformToolset=v100 --- examples/client/client.vcxproj | 9 +++- examples/client/client.vcxproj.props | 44 -------------------- examples/echoclient/echoclient.vcxproj | 9 +++- examples/echoclient/echoclient.vcxproj.props | 44 -------------------- examples/echoserver/echoserver.vcxproj | 9 +++- examples/echoserver/echoserver.vcxproj.props | 44 -------------------- examples/server/server.vcxproj | 9 +++- examples/server/server.vcxproj.props | 44 -------------------- sslSniffer/sslSniffer.vcxproj | 5 ++- sslSniffer/sslSniffer.vcxproj.props | 44 -------------------- testsuite/testsuite.vcxproj | 9 +++- testsuite/testsuite.vcxproj.props | 44 -------------------- wolfssl.vcxproj | 9 +++- wolfssl.vcxproj.props | 44 -------------------- 14 files changed, 52 insertions(+), 315 deletions(-) delete mode 100644 examples/client/client.vcxproj.props delete mode 100644 examples/echoclient/echoclient.vcxproj.props delete mode 100644 examples/echoserver/echoserver.vcxproj.props delete mode 100644 examples/server/server.vcxproj.props delete mode 100644 sslSniffer/sslSniffer.vcxproj.props delete mode 100644 testsuite/testsuite.vcxproj.props delete mode 100644 wolfssl.vcxproj.props diff --git a/examples/client/client.vcxproj b/examples/client/client.vcxproj index eed2b0f81..dec191d7a 100644 --- a/examples/client/client.vcxproj +++ b/examples/client/client.vcxproj @@ -40,41 +40,48 @@ Win32Proj - Application + v110 Unicode true Application + v110 Unicode true Application + v110 Unicode true Application + v110 Unicode true Application + v110 Unicode Application + v110 Unicode Application + v110 Unicode Application + v110 Unicode diff --git a/examples/client/client.vcxproj.props b/examples/client/client.vcxproj.props deleted file mode 100644 index 97cb4c2ec..000000000 --- a/examples/client/client.vcxproj.props +++ /dev/null @@ -1,44 +0,0 @@ - - - - - - v100 - - $(DefaultPlatformToolset) - - diff --git a/examples/echoclient/echoclient.vcxproj b/examples/echoclient/echoclient.vcxproj index 5ca5d43ad..a3a60545a 100644 --- a/examples/echoclient/echoclient.vcxproj +++ b/examples/echoclient/echoclient.vcxproj @@ -40,41 +40,48 @@ Win32Proj - Application + v110 Unicode true Application + v110 Unicode true Application + v110 Unicode true Application + v110 Unicode true Application + v110 Unicode Application + v110 Unicode Application + v110 Unicode Application + v110 Unicode diff --git a/examples/echoclient/echoclient.vcxproj.props b/examples/echoclient/echoclient.vcxproj.props deleted file mode 100644 index 97cb4c2ec..000000000 --- a/examples/echoclient/echoclient.vcxproj.props +++ /dev/null @@ -1,44 +0,0 @@ - - - - - - v100 - - $(DefaultPlatformToolset) - - diff --git a/examples/echoserver/echoserver.vcxproj b/examples/echoserver/echoserver.vcxproj index 09381a8f6..096ba75c6 100644 --- a/examples/echoserver/echoserver.vcxproj +++ b/examples/echoserver/echoserver.vcxproj @@ -40,41 +40,48 @@ Win32Proj - Application + v110 Unicode true Application + v110 Unicode true Application + v110 Unicode true Application + v110 Unicode true Application + v110 Unicode Application + v110 Unicode Application + v110 Unicode Application + v110 Unicode diff --git a/examples/echoserver/echoserver.vcxproj.props b/examples/echoserver/echoserver.vcxproj.props deleted file mode 100644 index 97cb4c2ec..000000000 --- a/examples/echoserver/echoserver.vcxproj.props +++ /dev/null @@ -1,44 +0,0 @@ - - - - - - v100 - - $(DefaultPlatformToolset) - - diff --git a/examples/server/server.vcxproj b/examples/server/server.vcxproj index 6581aece5..f6b53fc57 100644 --- a/examples/server/server.vcxproj +++ b/examples/server/server.vcxproj @@ -40,41 +40,48 @@ Win32Proj - Application + v110 Unicode true Application + v110 Unicode true Application + v110 Unicode true Application + v110 Unicode true Application + v110 Unicode Application + v110 Unicode Application + v110 Unicode Application + v110 Unicode diff --git a/examples/server/server.vcxproj.props b/examples/server/server.vcxproj.props deleted file mode 100644 index 97cb4c2ec..000000000 --- a/examples/server/server.vcxproj.props +++ /dev/null @@ -1,44 +0,0 @@ - - - - - - v100 - - $(DefaultPlatformToolset) - - diff --git a/sslSniffer/sslSniffer.vcxproj b/sslSniffer/sslSniffer.vcxproj index f00bf8e4b..56404e997 100644 --- a/sslSniffer/sslSniffer.vcxproj +++ b/sslSniffer/sslSniffer.vcxproj @@ -24,23 +24,26 @@ Win32Proj - DynamicLibrary + v110 Unicode true DynamicLibrary + v110 Unicode true DynamicLibrary + v110 Unicode DynamicLibrary + v110 Unicode diff --git a/sslSniffer/sslSniffer.vcxproj.props b/sslSniffer/sslSniffer.vcxproj.props deleted file mode 100644 index 97cb4c2ec..000000000 --- a/sslSniffer/sslSniffer.vcxproj.props +++ /dev/null @@ -1,44 +0,0 @@ - - - - - - v100 - - $(DefaultPlatformToolset) - - diff --git a/testsuite/testsuite.vcxproj b/testsuite/testsuite.vcxproj index a8c748918..484a87584 100644 --- a/testsuite/testsuite.vcxproj +++ b/testsuite/testsuite.vcxproj @@ -40,41 +40,48 @@ Win32Proj - Application + v110 Unicode true Application + v110 Unicode true Application + v110 Unicode true Application + v110 Unicode true Application + v110 Unicode Application + v110 Unicode Application + v110 Unicode Application + v110 Unicode diff --git a/testsuite/testsuite.vcxproj.props b/testsuite/testsuite.vcxproj.props deleted file mode 100644 index 97cb4c2ec..000000000 --- a/testsuite/testsuite.vcxproj.props +++ /dev/null @@ -1,44 +0,0 @@ - - - - - - v100 - - $(DefaultPlatformToolset) - - diff --git a/wolfssl.vcxproj b/wolfssl.vcxproj index c4b6840a3..8a95297e1 100644 --- a/wolfssl.vcxproj +++ b/wolfssl.vcxproj @@ -40,41 +40,48 @@ Win32Proj - StaticLibrary + v110 Unicode true DynamicLibrary + v110 Unicode true StaticLibrary + v110 Unicode true DynamicLibrary + v110 Unicode true StaticLibrary + v110 Unicode DynamicLibrary + v110 Unicode StaticLibrary + v110 Unicode DynamicLibrary + v110 Unicode diff --git a/wolfssl.vcxproj.props b/wolfssl.vcxproj.props deleted file mode 100644 index 97cb4c2ec..000000000 --- a/wolfssl.vcxproj.props +++ /dev/null @@ -1,44 +0,0 @@ - - - - - - v100 - - $(DefaultPlatformToolset) - -