WolfSSL
/
wolfssl
mirror of https://github.com/wolfSSL/wolfssl.git
1
0
Fork 0
Code Issues Releases Wiki Activity

sanity check on q value with DSA sign

pull/4480/head
Jacob Barthelmeh 2021-10-18 10:17:49 -06:00
parent 60adf22ce1
commit c07a7deec2
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/api.c
View File

@ -19594,6 +19594,9 @@ static int test_wc_DsaSignVerify (void)
mp_free(&key.q); mp_free(&key.q);
mp_init(&key.q); mp_init(&key.q);
AssertIntEQ(wc_DsaSign(hash, signature, &key, &rng), BAD_FUNC_ARG); AssertIntEQ(wc_DsaSign(hash, signature, &key, &rng), BAD_FUNC_ARG);
mp_set_int(&key.q, 1);
AssertIntEQ(wc_DsaSign(hash, signature, &key, &rng), BAD_FUNC_ARG);
#endif #endif
if (wc_FreeRng(&rng) && ret == 0) { if (wc_FreeRng(&rng) && ret == 0) {

6
wolfcrypt/src/dsa.c
View File

@ -762,6 +762,12 @@ int wc_DsaSign(const byte* digest, byte* out, DsaKey* key, WC_RNG* rng)
break; break;
} }
/* if q-1 is 0 or smaller, k will never end up being less than it */
if (mp_iszero(qMinus1) || mp_isneg(qMinus1)) {
ret = BAD_FUNC_ARG;
break;
}
do { do {
/* Step 4: generate k */ /* Step 4: generate k */
if ((ret = wc_RNG_GenerateBlock(rng, buffer, halfSz))) { if ((ret = wc_RNG_GenerateBlock(rng, buffer, halfSz))) {