WolfSSL
/
wolfssljni
mirror of https://github.com/wolfSSL/wolfssljni.git
1
0
Fork 0
Code Issues Releases Wiki Activity

JSSE: use single direct ByteBuffer in SSLEngine.SendAppData() instead of allocating each time method is called

pull/257/head
Chris Conlon 2025-04-10 15:10:43 -06:00
parent 1a7534c726
commit e8826acc4b
1 changed files with 23 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/java/com/wolfssl/provider/jsse/WolfSSLEngine.java
View File

@ -126,6 +126,10 @@ public class WolfSSLEngine extends SSLEngine {
private ByteBuffer netData = null; private ByteBuffer netData = null;
private final Object netDataLock = new Object(); private final Object netDataLock = new Object();
/* Single buffer used to hold application data to be sent, allocated once
* inside SendAppData, of size SSLSession.getApplicationBufferSize() */
private ByteBuffer staticAppDataBuf = null;
/* Locks for synchronization */ /* Locks for synchronization */
private final Object ioLock = new Object(); private final Object ioLock = new Object();
private final Object toSendLock = new Object(); private final Object toSendLock = new Object();
@ -590,17 +594,23 @@ public class WolfSSLEngine extends SSLEngine {
int[] pos = new int[len]; /* in[] positions */ int[] pos = new int[len]; /* in[] positions */
int[] limit = new int[len]; /* in[] limits */ int[] limit = new int[len]; /* in[] limits */
/* get total input data size, store input array positions */ /* Get total input data size, store input array positions */
for (i = ofst; i < ofst + len; i++) { for (i = ofst; i < ofst + len; i++) {
totalIn += in[i].remaining(); totalIn += in[i].remaining();
pos[i] = in[i].position(); pos[i] = in[i].position();
limit[i] = in[i].limit(); limit[i] = in[i].limit();
} }
/* only send up to maximum app data size chunk */ /* Allocate static buffer for application data, clear before use */
sendSz = Math.min(totalIn, sendSz = this.engineHelper.getSession().getApplicationBufferSize();
this.engineHelper.getSession().getApplicationBufferSize()); if (this.staticAppDataBuf == null) {
dataBuf = ByteBuffer.allocate(sendSz); /* allocate static buffer for application data */
this.staticAppDataBuf = ByteBuffer.allocateDirect(sendSz);
}
this.staticAppDataBuf.clear();
/* Only send up to maximum app data size chunk */
sendSz = Math.min(totalIn, sendSz);
/* gather byte array of sendSz bytes from input buffers */ /* gather byte array of sendSz bytes from input buffers */
inputLeft = sendSz; inputLeft = sendSz;
@ -608,7 +618,7 @@ public class WolfSSLEngine extends SSLEngine {
int bufChunk = Math.min(in[i].remaining(), inputLeft); int bufChunk = Math.min(in[i].remaining(), inputLeft);
in[i].limit(in[i].position() + bufChunk); /* set limit */ in[i].limit(in[i].position() + bufChunk); /* set limit */
dataBuf.put(in[i]); /* get data */ this.staticAppDataBuf.put(in[i]); /* get data */
inputLeft -= bufChunk; inputLeft -= bufChunk;
in[i].limit(limit[i]); /* reset limit */ in[i].limit(limit[i]); /* reset limit */
@ -618,8 +628,8 @@ public class WolfSSLEngine extends SSLEngine {
} }
dataArr = new byte[sendSz]; dataArr = new byte[sendSz];
dataBuf.rewind(); this.staticAppDataBuf.rewind();
dataBuf.get(dataArr); this.staticAppDataBuf.get(dataArr);
WolfSSLDebug.log(getClass(), WolfSSLDebug.INFO, WolfSSLDebug.log(getClass(), WolfSSLDebug.INFO,
"calling ssl.write() with size: " + sendSz); "calling ssl.write() with size: " + sendSz);
@ -2295,6 +2305,11 @@ public class WolfSSLEngine extends SSLEngine {
this.ssl.freeSSL(); this.ssl.freeSSL();
this.ssl = null; this.ssl = null;
} }
/* Clear our reference to static application direct ByteBuffer */
if (this.staticAppDataBuf != null) {
this.staticAppDataBuf.clear();
this.staticAppDataBuf = null;
}
super.finalize(); super.finalize();
} }
} }