* Avoid crash on stop if hamlib is somehow not able to initialize the radio.
* Need to use PTT type of RIGMICDATA in order for 'CAT via Data port' option to actually work.
* Use shared setHelperRealTime in internal WASAPI threads.
* Capture this instead of all by reference in internal WASAPI threads.
* Clean up refcounts of COM objects.
* Missed release of default audio device.
* Event handle needs to be closed on stop().
* Fix cross-compile definitions to allow asan to be used in the first place.
* Make sure TX/RX thread stops before audio devices do.
* FreeDV Reporter: Force re-sorting on user connect.
* Try unconditionally resorting on every pass through the timer.
* Bump up RX input FIFO to 30s. Yes, I know this is pretty excessive.
* Remove sortRequired_ since we're not using it anymore.
* Default to sorting by frequency.
* Re-attempt Hamlib connection without timeouts if failed.
* Add Hamlib error message to log.
* Remove timeouts.
* Only set ptt_pathname if using RTS or DTR.
* Various Hamlib fixes adapted from WSJT-X.
* Warning cleanup.
* Update changelog.
* Reset PTT type back to RIG to avoid issues when switching between RTS/DTR and CAT.
* Add support for CAT PTT using the Data port (vs. Mic).
* Update user manual.
* Automatically switch to new default audio device if the system loses existing one.
* Display error if non-default devices go away.
* Add device name to existing error strings.
* Add handler at engine level for device list changes. Does nothing yet.
* Prevent accidental deadlock when enqueuing functions onto ThreadedObject.
* Disable OnDeviceListChange logic; only handle active device disconnects.
* Attempt to restart devices if they stop unexpectedly.
* Defer stop to make sure remove handler runs first.
* Experiment: disable Python GC in RADE code to see if macOS pass rates improve.
* Fix possible deadlock issue in FreeDV Reporter code.
* Split out audio latency and PTT response time in logs per email discussion.
* Improve reliability of original PR logic by listening for AVAudioEngineConfigurationChangeNotification instead.
* Fix compiler error in GH environment.
* Make sure we join the new workgroup if the device ID changes.
* Remove unused code.
* Revert unnecessary ThreadedObject change.
* Remove extra whitespace.
* Revert ThreadedObject for real.
* Log audio underflows on macOS.
* Remove unneeded include.
* Get stuff off the audio thread that shouldn't be there.
* Make sure ThreadedObject doesn't hang.
* See if we can avoid FreeDV Reporter window crash on Windows.
* Tweak ThreadedObject event loop so we can execute more than one function between sleeps.
* Main window UI fixes:
1. Make FreeDV Mode indicator re-center itself every time it changes.
2. Add additional space for radio mode at bottom.
* Revert TapStep changes as we're better off not locking at all.
* Fix FreeDV Reporter tracking crash for real.
* Don't allow columns in FreeDV Reporter window to shrink.
* Warning cleanup.
* Try creating tiny column at end to fix Linux/Windows formatting problem.
* Remove minimum width logic as it didn't work.
* Sort equal items by connect time to keep rows stable.
* Fix deadlocks and crashes in the Audio Options window.
* Actually prevent same rows from moving around in FreeDV Reporter window.
* Deselect FreeDV Reporter row after filter change completes.
* Defer sending initial station info to FreeDV Reporter server until fully connected.
* Make sure we're not accessing invalid memory when getting audio device latency.
* Make sure PTT button is in the correct state when pushed.
* Fix From Mic plot rendering bug.
* Update changelog.
* WIP patch to wxWidgets to enable color emojis on Windows.
* WIP rewrite of FreeDV Reporter window to use wxDataViewCtrl.
* Apparently we need to associate the model before adding columns.
* Force render the Msg column using Direct2D, causing emojis to display in color.
* Move ReportMessageRenderer to a separate file.
* Only use ReportMessageRenderer on Windows. Also, make sure we don't show ellipsis unless for the Msg field.
* Bring back preservation of sort column.
* Bring back preservation of Msg column width.
* Support Request QSY functionality again.
* Fix rendering issues on macOS.
* Fix Windows compiler errors.
* Fix rendering issue on Windows from previous commits.
* Use correct selection foreground color when rendering with Direct2D.
* Set minimum column widths.
* Column headings should be centered.
* Batch up item changed notifications during refresh.
* Reenable clipboard and tooltip support.
* Ellipsize message text on Windows.
* Allow tooltips to at least show when clicking on a row.
* Have emojis display in color in tooltips as well.
* Add warning message when not building wxWidgets ourselves.
* Only notify of adding new connection if visible.
* Add additional checks around ItemAdded/ItemDeleted.
* Add/remove items individually every refresh to avoid intermittent Linux crashes.
* Defer memory deallocation until after the UI actually removes the item from view.
* Another attempt at fixing the crash.
* Need to validate pointer in GetAttr() too.
* Undo previous changes, try locking allReporterData_ instead.
* Fix Hamlib compiler failure due to changes in 4.6.
* Add some missed locks.
* Replace locks with assertions that we're on the main thread.
* Probably don't need to defer delete.
* Add additional checking around query methods.
* Warning cleanup.
* Make sure items are unselected before deleting.
* Unselect selected user once QSY request has been sent.
* Force a complete redraw when rows go away.
* Try another way of forcing a redraw.
* We only need to call Cleared() once per row.
* Improve CPU usage.
* Aggressively clear selected users when not actively interacting with them.
* Sort by connect time if no columns are selected for sorting.
* PAIn thread should be RT too (missed from previous PR).
* Force a re-sort on connect.
* Resort on every update from the server.
* Sort fix that hopefully doesn't crash.
* Some minor additional changes.
* Disable PAIn thread and just rely on the normal PulseAudio callbacks for passing audio in and out.
* Make re-sorting happen only once a second.
* Try putting mutexes around all data access.
* Increase RLIMIT_RTTIME just in case.
* Add missed locks.
* RT limit was set too high.
* Sleep for less time than latency if possible.
* Fix crash in TapStep while stopping.
* Defer FreeDV Reporter initialization on startup to make sure GUI is up beforehand.
* Try again to get RTKit to work in the GH environment.
* Try capping maxlength to avoid RX FIFO full errors.
* Increase max buffer size due to overrun errors.
* Default maxlength for output devices to prevent overruns.
* Try bringing back PAin thread. WIP
* Add missed PulseAudio locking.
* Remove more missed mallocs from RT path.
* Remove unneeded code from PulseAudio logic.
* Tab cleanup.
* Increase RX FIFO size.
* Force sleep if we take much longer than expected (avoids kill by rtkit).
* Forgot to check in file.
* Fix compiler error for real.
* Fix issue causing occasionally being unable to get the mic input on macOS.
* Add timeout for EOO in case we lose input devices.
* Add additional protection to prevent the OS from killing the app.
* macOS: get device names an alternate way to avoid empty names for certain devices.
* Make RX plots more reliable when pipewire sends multiple seconds of RX audio at once.
* Oops, used wrong comparison for EOO timeout.
* Catch SIGXCPU in case we exceed RT limits.
* Prevent RX processing from occurring if there's no space in the output FIFO.
* Apparently I was setting the soft and hard rlimits to be the same.
* Lower soft RT limit to 10ms.
* Disable RT scheduling on Linux.
* Added additional protection against server-caused race condition.
* Defer add to table until after we get connection successful message.
* Add missed lock on connect successful message.
* Add missed visibility check.
* Fix issue on Linux.
* Add additional logging to help diagnose duplicate callsign issue.
* Downgrade additional logging to debug/verbose only.
* Fix bug where incorrect SNR was being reported for RADE signals after EOO received.
* Back out previous change buffering rows until fully connected as it doesn't work properly on Windows.
* Fix right-click menu regression.
* Fix issue preventing column sorting on Windows.
* Upgrade wxWidgets to 3.2.8.
* Right-click should not select items.
* Add octave as a dependency for macOS build
* Add Octave to Linux required packages as well.
---------
Co-authored-by: Mooneer Salem <mooneer@gmail.com>
* Bound requested frames between both min and max.
* Request real-time scheduling for pipeline threads (currently macOS-only).
* Ensure pipeline threads never execute at the same time as audio threads.
* macOS: ask for 5ms audio blocks.
* Temporarily re-enable stress test.
* Suppress codespell for .mm files.
* Swap times/buffer sizes.
* Fix compiler error.
* Go back to previous frame size and time.
* Re-disable stress test.
* Try adjusting time quantum.
* Move audio priority handling to audio layer.
* Set helper thread to real-time on Windows.
* Temporarily disable audio workgroup code.
* Disable periodicity in macOS RT request
* Forgot to define variable.
* Only allow a max of 50% CPU time for audio helpers.
* More tuning of the duty cycle.
* Make sure we sleep some amount of time every time through the loop.
* Go back to smaller time quantum.
* Another quantum tweak.
* Increase audio sample block size to 20ms.
* Use 2.5ms for audio block time.
* Try increasing FIFO sizes for RX.
* Oops, forgot to comment out the / 1000 too.
* Get faster turnaround for macOS GH builds.
* Revert FIFO changes.
* Add additional debugging.
* Fix compiler error.
* Fix typo.
* Use semaphores to notify TX/RX worker threads.
* Try dividing duty cycle by 2 to avoid starvation.
* Reenable audio workgroups.
* No point in having parallel threads if only one mode is active.
* Ensure that ParallelStep gets added to the audio workgroup too.
* Anything for GUI consumption shouldn't be in the RT path.
* Go back to 10ms audio blocks to see if reporting tests can more reliably pass.
* Fix issue causing audio to not work on certain Macs.
* Support real-time threading on Linux when using PulseAudio/pipewire.
* Fix misspelling.
* dbus needs to be installed in the environment.
* macOS: try a smaller block size again.
* Revert "macOS: try a smaller block size again."
This reverts commit 1d21ad6934.
* Try architecture-specific audio block times.
* rtkit itself also needs to be installed in the environment.
* Revert ordering changes to macOS CI builds.
* GH user needs to be added to rtkit group.
* Implement semaphores on Windows.
* Don't exit the render/capture threads unless requested by higher level code.
* Don't take address of a pointer.
* macOS: set thread QoS for RT threads.
* Move RADE RX/TX memory allocations out of real-time path.
* Moving additional memory allocations outside of RT context.
* Move all remaining allocations in pipeline outside of RT except for legacy FreeDV modes.
* Longer audio block times don't seem to be making a difference.
* Move legacy mode memory allocations out of RT context.
* Prevent unbounded mutex locks inside pipeline.
* Windows: fallback to a simple sleep if we can't lock the semaphore.
* Increase maximum wait time to match what Windows returns for buffer size.
* PulseAudio: fallback to simple sleep if we can't wait on semaphore.
* Prevent unbounded locking in TapStep.
* Initial warning cleanup.
* Fix issue causing audio to not work on certain Macs.
* Fix compiler error.
* Fix remaining MacAudioDevice warnings.
* Fix more warnings.
* Fix Hamlib compiler failure due to changes in 4.6.
* Fix websocketpp related warnings on Linux.
* Fix issue causing waterfall rendering issues.
* Fix additional warnings when compiling on Linux.
* Create FIFOs with correct sizes to reduce EOO time.
* Try using configured fifo size for all FIFOs.
* Use correct variable names when definining FIFO sizes.
* Update wxWidgets to 3.2.7 to see if that fixes the build failure.
* Use Ubuntu 24.04 for Windows build to match Linux.
* Patch libsamplerate to avoid GH action failure.
* Need to remove 3.1 from samplerate-cmake.patch
* Fix issue causing cmake to hang if being rerun.
* Temporarily use wxWidgets master as latest Xcode can't build 3.2.7.
* Add support for rig control during RADE EOO ctests.
* Try adding a bit of time to see if it'll decode.
* Fix GH action failure.
* Fix Windows build failure.
* Use same delay code as other existing similar logic.
* Add 20ms delay in mock rigctld to better match behavior with actual hardware.
* Fix Windows build issue for real.
* Fix samplerate patch issue.
* Include wxWidgets manifest code since 3.3 will soon require it.
* Use 3.2 branch as we can build on macOS now in that branch.
* Add IAudioDevice function to allow retrieval of device latency.
* Try shrinking the number of samples FreeDVInterface returns for RADE.
* Add missed get() call in PortAudio logic.
* We really shouldn't need to add txIn latency.
* We need to see the logs from when TX happens during ctest.
* Explicitly disable power savings for audio (macOS).
* Allow partial reads from TX output FIFO.
* First pass at calculating latency for WASAPI.
* Try IO frame size of 1024 to improve pass rate of GH Actions.
* Initial implementation of RADE reporting test on Windows.
* Remove unneeded flag from previously added script.
* Fix various issues with PS script.
* Revert "Try IO frame size of 1024 to improve pass rate of GH Actions."
This reverts commit 1161d9505d.
* Use FDV output, not mock rigctl output, for comparison.
* Use GetStreamLatency() instead.
* Add logging to help determine why WASAPI latency is incorrect.
* Need GetDevicePeriod as well for fully accurate latency measurements.
* Buffer size is the minimum bound on latency. Or at least it seems like it would be, anyway.
* Guarantee that we have universal macOS binary even if tests fail.
* Also take into account PTT response time (i.e. for SDRs).
* Only need to add half of the rig response time for good results.
* Forgot implementation of getRigResponseTimeMicroseconds() for OmniRig.
* Prevent negative zero SNRs from appearing in GUI.
* Try smallest buffer size possible for macOS audio.
* Fix macOS compiler error.
* (Windows) Use event based triggering to provide audio to/from FreeDV.
* Divide by number of channels to get actual latency on macOS.
* Increase minimum frame size to 128 on macOS.
* Oops, types need to be the same.
* Fix deadlock in Windows audio from previous commits.
* Try 256 buffer size on macOS.
* Use minimum of 40ms latency on macOS and Windows.
* No need for the samplerate patch anymore.
* Fix comments.
* Initial implementation of macOS audio handling using native APIs.
* Fix minor calculation issue in Easy Setup when generating sine waves.
* Fix spelling error.
* Fix issue causing distorted output audio.
* Refactor audio device info retrieval to a separate method.
* Get channel information for discovered macOS audio devices.
* Add support for retrieving default audio devices.
* Try using AVAudioSinkNode for getting mic/RX audio.
* Use AVAudioSourceNode for output side too.
* Fix compiler error.
* Set minimum macOS version to 10.15 due to PyTorch and new audio code requiring it.
* Disable universal build in GH action to make it run a bit faster.
* Additionally use Homebrew packages as deps instead of building own for GH action.
* Don't build hamlib if BUILD_DEPS is 0.
* Use matrix to test macOS build on both x86_64 and ARM64.
* Experiment: always sleep for 10ms every time through the TX/RX loop.
* Temporarily enable longer tests to make sure previous pass wasn't a fluke.
* Remove logic not available in 10.15.
* Revert "Experiment: always sleep for 10ms every time through the TX/RX loop."
This reverts commit 6019c9a522.
* Need to query valid sample rates from Core Audio.
* Validate provided sample rate and channel data when creating audio object.
* Set device sample rate to user-configured option.
* Sample rates could be different between input and output.
* Revert "Temporarily enable longer tests to make sure previous pass wasn't a fluke."
This reverts commit f90c4cd081.
* Remove now unused code.
* Harmonize native vs. PortAudio config across build scripts.
* Zero out audio by default to prevent buzzing.
* Update README to use new environment variable for audio driver control.
* Add COM wrapper class around ThreadedObject. Prerequisite for WASAPI audio support.
* Disable OLE 1.0 per Windows documentation.
* WIP WASPI device enumeration.
* Forgot to check in some changes.
* Fix compiler errors.
* Avoid deadlock during sample rate list retrieval.
* s/WASPI/WASAPI/g
* WIP WASAPIAudioDevice design.
* Full WASAPIAudioDevice implementation.
* Increase priority of audio tasks to prevent dropouts.
* Add missed nullptr initialization.
* Increase buffer time to 40ms
* Fix issue where non-English device names were getting corrupted.
* Add additional logging.
* Need to create macOS audio device name just like with Windows.
* Update README to document new config options.
* Fix fargan_config.h issue when not building universal binaries.
* Add additional dependencies to force RADE to be built first.
* Try matrix build of macOS to verify both universal and non-universal builds.
* Fix syntax error.
* Update conditionals to actually evaluate properly.
* Need single quotes for matrix comparison.
* Bring back original permissions workaround for some builds.
* Oops, copied the wrong permissions lines from previous commit.
* Revert GH action changes.
* Update build scripts to use optimal number of parallel builds.
* Update Windows GH action similarly to other build scripts.
* Add PR #842 to changelog.
* Need -j6 for Windows for some reason.
* Increase Windows test timeouts.
* -j doesn't actually limit the number of parallel builds.
* Embed sioclient source code into FreeDV codebase.
* Exclude 3rdparty from spellcheck.
* Revert "Embed sioclient source code into FreeDV codebase."
This reverts commit 2021118544.
* Embed ZIP file with sioclient code instead of individual files.
* Generate tarball on Linux as CMake behaves weird with a macOS-created ZIP file.
* Add json and websocketpp source files.
* Add ThreadedTimer (prerequisite for own socket.io implementation).
* Adapt ezDV implementation of sioclient.
* Update FreeDVReporter to use our SocketIoClient.
* Fix bugs preventing connection to FreeDV Reporter server.
* Read all data available every 50ms.
* Fix bug preventing hide/show from working properly.
* Remove sioclient tarball and build logic.
* Fix Linux build issue.
* Work around exception bug on object destruction.
* Fix Windows build failure.
* Ensure that connection is actually closed if we stop being in contact with the server.
* Fix additional segfault on exit.
* Sockets on Windows aren't actually fully POSIX.
* Use ulog for websocketpp logging.
* Update comments in recently added files.
* Additional logging cleanup.
* Show IP address that failed connection.
* Reduce websocketpp buffer size to match what's used in our read logic.
* Fix spelling error.
* Fix issue with corrupted IP addresses being logged.
* Add additional logic to make absolutely sure we're done with DNS.
* Make sure whichIndex is valid once we complete DNS.
* Widen Mode field on bottom of main window.
* Extend RADEv1 unit test time to try to force failures.
* txrx test wasn't actually respecting -txtime.
* Increase test length to 10min.
* Increase timeout.
* Temporarily disable macOS and Linux workflows.
* Run RADE test 10 times.
* Tweak to hopefully cause Windows test to actually fail.
* Ensure that all PortAudio calls are executed from the same thread.
* Use exclusive mode for radio devices for lower latency (at least on Windows).
* Reduce TX/RX thread delay to 10ms.
* Increase GH action timeout.
* Oops, need to tell PortAudio to actually set thread priority.
* Suggest low latency to PortAudio.
* Revert 10ms max wait.
* Try forcing shared mode again.
* Revert "Try forcing shared mode again."
This reverts commit cd025e9a8e.
* Revert "Revert 10ms max wait."
This reverts commit 0227ce5f0c.
* Reenable macOS/Linux builds.
* Run RADE tests 10x on Linux and macOS.
* Revert back to 60s tests on macOS/Linux.
* Use sh -c to run test.
* Try defining FPB as 0.
* Split out repeated RADE test into a separate ctest.
* Disable GH action timeout for Windows tests.
* Fix CMakeLists.txt error.
* Try increasing the timeout back to 20ms again.
* Back to 10ms.
* macOS: minimize CPU usage inside PortAudio.
* Use higher quality macOS settings.
* Use Intel macOS runner as it has more cores and RAM.
* Add debug output so we can adapt GH action for Intel.
* Fix gfortran path based on debug output.
* Fix permissions database issue.
* Disable exclusive mode due to invalid device errors.
* Disable stress tests in GitHub environment by default.
* Restructure TX out code to help the compiler optimize for the common case.
* Forgot to disable the repeated test.
* Use VB-Cable for radio device on macOS due to improved reliability.
* Fix side issue reported in original issue surrouding default mode selection.
* Need to restrict number of runs to 1 for RADE on Windows.
* Remove unnecessary API for setting exclusive mode.
* Wrap sync flag in std::atomic just in case the GH failures are actually threading related.
* Add PR #840 to changelog.
* Save Hamlib rig names on startup as they're able to change out from under us.
* Bump up Hamlib to 4.6.2.
* Add PR #834 to changelog.
* Capture rig names after sorting the rig list. This ensures that the rig names are in the same order as the main list.
* Append -D to USB/LSB if radio is using digital variant.
* Don't adjust Msg column width when user disconnects.
* Add PR #828 to changelog.
* Don't cause Msg col to be resized when it changes (i.e. on user connect).
* Add back 4+ character commit ID to version.
* Clarify purpose of extra space at beginning of truncated message.
* Fix issue preventing suppression of the Msg tooltip for non-truncated messages.
* Add PR #829 to changelog.
Mooneer Salem
Peter B Marks
dforsi