Add note on using itertools.dropwhile() for efficiency in _is_allowed().

* If/when it's rewritten, a simple speed/efficiency check can be done with:
   >>> import dis
   >>> dis.dis(_is_allowed_orig('--dragons'))
   >>> dis.dis(_is_allowed_orig('--encrypt'))
   >>> dis.dis(_is_allowed_new('--dragons'))
   >>> dis.dis(_is_allowed_new('--encrypt'))
testing/mmn/mktime_takes_localtime_not_gmtime
Isis Lovecruft 2013-05-27 07:19:40 +00:00
parent 69c6981b66
commit f65022500d
No known key found for this signature in database
GPG Key ID: A3ADB67A2CDB8B35
1 changed files with 1 additions and 0 deletions

View File

@ -404,6 +404,7 @@ def _is_allowed(input):
hyphenated = _hyphenate(input)
else:
hyphenated = input
## xxx we probably want to use itertools.dropwhile here
try:
assert hyphenated in allowed
except AssertionError as ae: