Commit Graph

2504 Commits (bfbf0edbb979603ce165a65a0f7101467647a3f2)

Author SHA1 Message Date
John Safranek bfbf0edbb9 7-bit Clean ASCII
Clean up the main set of files to be 7-bit clean ASCII. There were many
single and double-quotes and n-dashes.
2026-04-22 10:27:06 -07:00
John Safranek afedde7a1d Fix Potential Double Free
Static analysis indicated the potential to double-free a pointer in the
`wolfSSH_CTX_UseCert_buffer()` test. Loading the second cert after
freeing the first cert could fail and the test cleanup would free the
pointer again. Just set pointer to null after freeing.
2026-04-22 10:27:06 -07:00
Yosuke Shimizu 19d34a8df7 Add auth tests to verify cases of invalid/unknowen return value 2026-04-22 08:32:24 -07:00
Yosuke Shimizu e7226d0f29 Add unit test for wolfSSH_RsaVerify 2026-04-22 08:25:13 -07:00
Paul Adelsbach 90c0ee6a7c Add zeroization in wolfSSH_ProcessBuffer 2026-04-21 16:25:12 -07:00
Paul Adelsbach 3f03a851c5 Fix word16 truncation in internal.c 2026-04-21 16:24:01 -07:00
Paul Adelsbach aa974545a0 Fix uninit variable in KeyAgreeEcdh_server 2026-04-21 16:20:30 -07:00
Paul Adelsbach 1cb644d2d4 Fix Nucleus log variable 2026-04-21 16:19:18 -07:00
Yosuke Shimizu cd7a7f47c3 Fix DoChannelRequest and Add unit test for DoChannelRequest 2026-04-21 16:18:24 -07:00
Paul Adelsbach 0d283d2dd3 Add check for all zeros in CreateMpint 2026-04-21 16:03:08 -07:00
Yosuke Shimizu b007310fa2 Fix wolfSSH_RealPath tests 2026-04-21 16:01:41 -07:00
John Safranek 2d981ae87b
Merge pull request #930 from yosuke-wolfssl/f_2073
Add wc_Sha256Free after the final use
2026-04-21 15:55:22 -07:00
John Safranek 6d09901166
Merge pull request #924 from yosuke-wolfssl/f_2485
Add kex integration test for ed25519 server key
2026-04-21 11:14:26 -07:00
John Safranek a608f1944f
Merge pull request #923 from yosuke-wolfssl/f_2484
Add additional regress test for DoKexDhReply
2026-04-21 09:46:43 -07:00
John Safranek 8552be0cc5
Merge pull request #938 from padelsbach/require-wolfssh-cert
Require wolfssl to be built with --enable-wolfssh
2026-04-21 09:34:19 -07:00
Paul Adelsbach 2b0cc74e30 Require wolfssl to be built with --enable-wolfssh 2026-04-21 09:22:11 -07:00
John Safranek 87c0b05d72 Userauth none bypasses wolfSSHd credential check
When wolfsshd is built with WOLFSSH_ALLOW_USERAUTH_NONE, the
DefaultUserAuth() function accepted WOLFSSH_USERAUTH_NONE as a valid
auth type and forwarded it to RequestAuthentication(). Since
RequestAuthentication() only gates credential checks on PASSWORD and
PUBLICKEY types, a none request for any existing system user returned
success without verifying any credential. Removed USERAUTH_NONE as an
accepted auth type in DefaultUserAuth() so it is treated as an invalid
auth type for wolfsshd.

Affected function: DefaultUserAuth.
Issue: F-3215
2026-04-21 09:20:12 -07:00
John Safranek 2568b26b84
Merge pull request #914 from padelsbach/negative-test-cases
Add negative test case for CheckPasswordHashUnix
2026-04-20 11:26:04 -07:00
John Safranek 8efa825d18
Merge pull request #937 from yosuke-wolfssl/f_865
Fix DoUserAuthBanner()
2026-04-20 11:02:05 -07:00
Paul Adelsbach 80da96eebb Add negative test case for CheckPasswordHashUnix 2026-04-20 09:58:07 -07:00
Yosuke Shimizu fe89681f9b Add unit test for DoUserAuthBanner 2026-04-20 17:05:05 +09:00
Yosuke Shimizu c3c51530e1 Fix DoUserAuthBanner() 2026-04-20 16:33:46 +09:00
John Safranek 8643d7be84
Merge pull request #933 from JacobBarthelmeh/release
prepare for release 1.5.0
2026-04-17 18:03:22 -07:00
John Safranek 6b89cb75c7
Merge pull request #928 from JacobBarthelmeh/cpp
fixes for c++ error on missing enum cast and warning on MlKemKey init
2026-04-17 10:34:09 -07:00
John Safranek 0049c55b1b
Merge pull request #931 from yosuke-wolfssl/f_2074
Fix wolfSSHD_ConfigCopy and wolfSSHD_ConfigFree
2026-04-17 10:24:29 -07:00
JacobBarthelmeh 2712061d98 prepare for release 1.5.0 2026-04-17 10:49:48 -06:00
JacobBarthelmeh 6638054582
Merge pull request #932 from yosuke-wolfssl/f_2075
Fix FingerprintKey
2026-04-17 09:36:25 -06:00
Yosuke Shimizu 2608f90fa1 Fix FingerprintKey 2026-04-17 17:52:30 +09:00
Yosuke Shimizu 97a0c7b5b7 Fix wolfSSHD_ConfigCopy and wolfSSHD_ConfigFree, and Add the regression test 2026-04-17 17:31:40 +09:00
Yosuke Shimizu 5bb1260466 Add wc_Sha256Free after the final use 2026-04-17 11:17:12 +09:00
JacobBarthelmeh 6013f122b4 check on return value of get digest size and remove old ret reset code 2026-04-16 17:27:59 -06:00
JacobBarthelmeh 8a945c7b35 fixes for c++ error on missing enum cast and warning on MlKemKey initialization 2026-04-16 16:31:43 -06:00
John Safranek 91cbb647d1
Merge pull request #926 from JacobBarthelmeh/dist
fixes for make distcheck
2026-04-16 15:14:37 -07:00
JacobBarthelmeh 422d4ed53a add example ecc keys also to ac config link for out of tree builds 2026-04-16 15:57:28 -06:00
JacobBarthelmeh 9e80de70a5 fixes for make distcheck 2026-04-16 15:50:54 -06:00
JacobBarthelmeh f4b7786b0b
Merge pull request #922 from ejohnstown/check-dhgroup
Validate server's group
2026-04-16 14:56:30 -06:00
John Safranek 16ddcd9764 Validate server's group
The client wasn't validating the DH group parameters in the KEX DH GEX
Group message. This adds a function to perform the validation of the
prime `p` to verify it is safe. (Prime and that ((p - 1) / 2) is
prime.) Also adds a test to a known unsafe prime and known safe prime
to verify the validate function.

Affected function: DoKexDhGexGroup.
Issue: F-1688
2026-04-16 13:42:24 -07:00
JacobBarthelmeh bf85bab6fb
Merge pull request #918 from yosuke-wolfssl/f_2867
Fix DoGlobalRequestFwd() so that it rejects the port forwarding if no fwdCb is set.
2026-04-16 09:30:30 -06:00
Yosuke Shimizu 651e4cae8a Add kex integration test for ed25519 server key 2026-04-16 15:14:42 +09:00
Yosuke Shimizu fd82a4bcf5 Fix DoGlobalRequestFwd and Add the regress tests 2026-04-16 13:11:29 +09:00
Yosuke Shimizu 7beec434db Add regress test for DoKexDhReply 2026-04-16 10:10:50 +09:00
JacobBarthelmeh 85cf3e7c25
Merge pull request #921 from ejohnstown/expect-newkeys
Fix server NEWKEYS message expectation
2026-04-15 16:59:13 -06:00
JacobBarthelmeh cdd6df0c38
Merge pull request #919 from yosuke-wolfssl/f_2871
Fix DoChannelOpen() and Add the regress test
2026-04-15 15:33:01 -06:00
JacobBarthelmeh f291d99e6f
Merge pull request #917 from yosuke-wolfssl/f_2471
Fix DoKexDhReply() to reject the server's pub key if no PublicKeyCheck callback is registered
2026-04-15 15:29:53 -06:00
JacobBarthelmeh 53ae73b14e
Merge pull request #920 from yosuke-wolfssl/f_2880
Fix DoChannelOpenConf
2026-04-15 15:25:19 -06:00
JacobBarthelmeh 346c5c11cc
Merge pull request #916 from yosuke-wolfssl/f_2861
Fix PostSignRequest
2026-04-15 14:59:02 -06:00
John Safranek 543a6c2a2f
Merge pull request #915 from padelsbach/const-time-auth
Replace WMEMCMP in CheckAuthKeysLine
2026-04-15 09:20:46 -07:00
Yosuke Shimizu e72022acc0 Fix DoChannelOpenConf 2026-04-15 16:58:56 +09:00
Yosuke Shimizu 0317c40fc1 Fix DoChannelOpen() and Add regress test 2026-04-15 13:52:23 +09:00
Yosuke Shimizu 9e3eee1276 Fix existing tests 2026-04-15 11:04:09 +09:00