1. For the Query name by index functions, rename `index` as `idx`. Some
versions of the C library have a global named `index` that can get
shadowed.
2. Fix some whitespace.
1. Update the version requirements of libtool, automake, and autoconf to
version contemporary to the first release of wolfSSH.
2. Group all checks of `ENABLED_TPM` into one `AS_IF`.
3. Group all checks of `ENABLED_SSHD` into one `AS_IF`.
4. Replace `if` and `case` with `AS_IF` and `AS_CASE`.
1. Due to not checking the result of fseek(), it is possible to try to
malloc() -1 bytes of storage. Checking the return from fseek() and
erring if negative.
2. Changing the check between the result of fseek() and fread() to match
signedness. Adding some casting, as at that point the fseek() result
is always positive.
Fixes CIDs:
573009 572928 572868
1. When cleaning the path, check that the path pointer is not null
before using it.
2. Move the strlen of path.
3. Remove the second check of path, and just loop over it.
Fixed CID: 572847
1. Modify all the test executable `CPPFLAGS` to only have
`-DNO_MAIN_LOOP` and `AM_CPPFLAGS`. This removes a lot of duplicate
setup of flags for each of the tests.
2. Delete the echoserver's `CFLAGS`. It is just setting the `CFLAGS` for
its compile to `AM_CFLAGS` and `AM_CPPFLAGS` which are included by
default.
3. Add the macro WS_MAYBE_UNUSED that may be the unused attribute.
4. If INLINE isn't set to some form of inline, set it to
WS_MAYBE_UNUSED.
5. Remove redundant ThreadStartNoJoin() macros from the testing header.
1. Remove the default password from the wolfSSH client app main
function. It isn't set to anything. (It was originally an example
client option.)
2. Remove handling the default password from the wolfSSH client app's
user authentication callback.
3. Set the password size directly.
4. Changed a void typecast to WOLFSSH_UNUSED.
Fixes CID: 572898
1. Fix some resource leaks during error conditions where a socket or a
file descriptor doesn't get closed in all error cases.
2. In wolfSSH_SFTP_RecvOpen(), initialize the file descriptor.
3. For 572902, the error case resource leaks are fixed. There's still an
issue to resolve for storing the FD for use later.
Fixes CIDs:
572856 572902* 573012 573019 573021 573076
1. Modify AssertNotNull() to use the same pattern as AssertNull(). The
macro assigns the pointer to a local variable and that is checked.
Fixes CIDs:
537020 573008 573010 573011 573013 573014 573015
573016 573017 573018 573022 573023 573024
gojimmypi
John Safranek
JacobBarthelmeh
Kareem
Timo Kokkonen
Ruby Martin
David Garske
Daniel Pouzzner
Sebastian Carpenter